You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/03/25 03:01:50 UTC
[GitHub] [shardingsphere] lanchengx opened a new pull request #16354: Optimize `ALTER INSTANCE SET XA_RECOVERY_ID`
lanchengx opened a new pull request #16354:
URL: https://github.com/apache/shardingsphere/pull/16354
For https://github.com/apache/shardingsphere/issues/15405
Changes proposed in this pull request:
- change XA_RECOVERY_ID to `XA_RECOVERY_NODES`
- Update parse test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jingshanglu commented on a change in pull request #16354: Optimize `ALTER INSTANCE SET XA_RECOVERY_ID`
Posted by GitBox <gi...@apache.org>.
jingshanglu commented on a change in pull request #16354:
URL: https://github.com/apache/shardingsphere/pull/16354#discussion_r834928500
##########
File path: shardingsphere-test/shardingsphere-parser-test/src/main/resources/sql/supported/ral/common.xml
##########
@@ -52,6 +52,6 @@
<distsql-case id="prepare-distsql" value="PREPARE DISTSQL" />
<distsql-case id="apply-distsql" value="APPLY DISTSQL" />
<distsql-case id="discard-distsql" value="DISCARD DISTSQL" />
- <distsql-case id="alter-instance-xa-recovery-id" value="ALTER INSTANCE 1.2.3.4@3307 SET XA_RECOVERY_ID=ID_TEST" />
+ <distsql-case id="alter-instance-xa-recovery-nodes" value="ALTER INSTANCE 1.2.3.4@3307 SET XA_RECOVERY_NODES=1.2.3.4@3308" />
Review comment:
It maybe better to add a case like
```
ALTER INSTANCE 1.2.3.4@3307 SET XA_RECOVERY_NODES=1.2.3.4@3308,1.2.3.4@3307;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jingshanglu commented on a change in pull request #16354: Optimize `ALTER INSTANCE SET XA_RECOVERY_ID`
Posted by GitBox <gi...@apache.org>.
jingshanglu commented on a change in pull request #16354:
URL: https://github.com/apache/shardingsphere/pull/16354#discussion_r834927269
##########
File path: shardingsphere-distsql/shardingsphere-distsql-parser/src/main/antlr4/imports/RALStatement.g4
##########
@@ -171,6 +171,10 @@ variableName
: IDENTIFIER
;
+variableValues
+ : variableValue (COMMA variableValue)*?
+ ;
+
Review comment:
Maybe It is ok like this
```
variableValues
: variableValue (COMMA variableValue)*
;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] lanchengx commented on a change in pull request #16354: Optimize `ALTER INSTANCE SET XA_RECOVERY_ID`
Posted by GitBox <gi...@apache.org>.
lanchengx commented on a change in pull request #16354:
URL: https://github.com/apache/shardingsphere/pull/16354#discussion_r834929054
##########
File path: shardingsphere-test/shardingsphere-parser-test/src/main/resources/sql/supported/ral/common.xml
##########
@@ -52,6 +52,6 @@
<distsql-case id="prepare-distsql" value="PREPARE DISTSQL" />
<distsql-case id="apply-distsql" value="APPLY DISTSQL" />
<distsql-case id="discard-distsql" value="DISCARD DISTSQL" />
- <distsql-case id="alter-instance-xa-recovery-id" value="ALTER INSTANCE 1.2.3.4@3307 SET XA_RECOVERY_ID=ID_TEST" />
+ <distsql-case id="alter-instance-xa-recovery-nodes" value="ALTER INSTANCE 1.2.3.4@3307 SET XA_RECOVERY_NODES=1.2.3.4@3308" />
Review comment:
it was provided to openForce https://github.com/apache/shardingsphere/issues/16357
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] lanchengx commented on a change in pull request #16354: Optimize `ALTER INSTANCE SET XA_RECOVERY_ID`
Posted by GitBox <gi...@apache.org>.
lanchengx commented on a change in pull request #16354:
URL: https://github.com/apache/shardingsphere/pull/16354#discussion_r834928518
##########
File path: shardingsphere-distsql/shardingsphere-distsql-parser/src/main/antlr4/imports/RALStatement.g4
##########
@@ -171,6 +171,10 @@ variableName
: IDENTIFIER
;
+variableValues
+ : variableValue (COMMA variableValue)*?
+ ;
+
Review comment:
Right!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jingshanglu merged pull request #16354: Optimize `ALTER INSTANCE SET XA_RECOVERY_ID`
Posted by GitBox <gi...@apache.org>.
jingshanglu merged pull request #16354:
URL: https://github.com/apache/shardingsphere/pull/16354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org