[GitHub] [geode] kirklund commented on a change in pull request #5978: GEODE-8894 allow individual deltas to trigger bucket size recalculation

[GitBox <gi...@apache.org>]

kirklund commented on a change in pull request #5978:
URL: https://github.com/apache/geode/pull/5978#discussion_r573346872



##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/EntryEventImpl.java
##########
@@ -1713,10 +1713,11 @@ private void setNewValueInRegion(final InternalRegion owner, final RegionEntry r
     // This is a horrible hack, but we need to get the size of the object
     // When we store an entry. This code is only used when we do a put
     // in the primary.
-    if (v instanceof org.apache.geode.Delta && getRegion().isUsedForPartitionedRegionBucket()) {
+    if (v instanceof Delta && getRegion().isUsedForPartitionedRegionBucket()) {
       int vSize;
       Object ov = basicGetOldValue();
-      if (ov instanceof CachedDeserializable && !GemFireCacheImpl.DELTAS_RECALCULATE_SIZE) {
+      if (ov instanceof CachedDeserializable && !(GemFireCacheImpl.DELTAS_RECALCULATE_SIZE

Review comment:
       Please add unit test coverage to EntryEventImplTest for any changes to EntryEventImpl.
   
   You don't need to add tests tests for importing org.apache.geode.Delta, but anything that involves touching the logic or behavior like this block should have unit test coverage in addition to integration/distributed tests.

##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/EntryEventImpl.java
##########
@@ -1858,7 +1859,8 @@ private void processDeltaBytes(Object oldValueInVM) {
       if (wasCD) {
         CachedDeserializable old = (CachedDeserializable) oldValueInVM;
         int valueSize;
-        if (GemFireCacheImpl.DELTAS_RECALCULATE_SIZE) {
+        if (GemFireCacheImpl.DELTAS_RECALCULATE_SIZE

Review comment:
       Same here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org