[GitHub] [maven-artifact-transfer] cstamas commented on pull request #24: [MSHARED-987] Make use of SISU

[GitBox <gi...@apache.org>]

cstamas commented on pull request #24:
URL: https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-829348216


   As mentioned above UTs pass OK
   The ITs pass, **except for maven 3.0.5**, reason: it seems it was not yet honoring "sisu index" (`META-INF/sisu/javax.inject.Named`). (ProjectInstaller pass OK, as it does not invoke 3.0.x).
   
   Now, **this is a reason** to drop 3.0.x line, as I don't want to write anymore `plexus.xml`, while we have SISU.
   
   Essentially, this means that regarding "components" maven 3.0.x and 3.1.x line "speak different languages". Maven 3.1.x+ "knows" sisu-index, while maven 3.0.x does NOT. IMO, I see really no reason to support 3.0.x.
   
   Please test this, inspect ITs and ping here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org