You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by cakofony <gi...@git.apache.org> on 2017/10/26 15:05:01 UTC
[GitHub] logging-log4j2 pull request #120: Log4j respects the configured "log4j2.is.w...
GitHub user cakofony opened a pull request:
https://github.com/apache/logging-log4j2/pull/120
Log4j respects the configured "log4j2.is.webapp" property
Some applications run embedded servlet containers sharing
a single logging context from the root application.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cakofony/logging-log4j2 is_webapp
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/logging-log4j2/pull/120.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #120
----
commit e5f18e5e7715061f9aeea9d264c5070c32e8aac4
Author: Carter Kozak <c4...@gmail.com>
Date: 2017-10-26T15:02:28Z
Log4j respects the configured "log4j2.is.webapp" property
Some applications run embedded servlet containers sharing
a single logging context from the root application.
----
---
[GitHub] logging-log4j2 issue #120: LOG4J2-2091: Log4j respects the configured "log4j...
Posted by jvz <gi...@git.apache.org>.
Github user jvz commented on the issue:
https://github.com/apache/logging-log4j2/pull/120
I think you could add a simple test in log4j-web that asserts `Constants.IS_WEB_APP` if there isn't one already.
---
[GitHub] logging-log4j2 pull request #120: LOG4J2-2091: Log4j respects the configured...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/logging-log4j2/pull/120
---
[GitHub] logging-log4j2 issue #120: LOG4J2-2091: Log4j respects the configured "log4j...
Posted by cakofony <gi...@git.apache.org>.
Github user cakofony commented on the issue:
https://github.com/apache/logging-log4j2/pull/120
Updated, thanks for the feedback!
---
[GitHub] logging-log4j2 issue #120: LOG4J2-2091: Log4j respects the configured "log4j...
Posted by cakofony <gi...@git.apache.org>.
Github user cakofony commented on the issue:
https://github.com/apache/logging-log4j2/pull/120
Hi @jvz, thanks for the quick reply!
I've added a jira ticket, but I'm not sure the best way to add real tests for this given how this is configured as static state. Any chance you could point me in the right direction?
---
[GitHub] logging-log4j2 issue #120: Log4j respects the configured "log4j2.is.webapp" ...
Posted by jvz <gi...@git.apache.org>.
Github user jvz commented on the issue:
https://github.com/apache/logging-log4j2/pull/120
This PR looks good, though could you associate this with a JIRA ticket? Also, a unit test would be great to help avoid this bug from resurfacing in the future. Thanks!
---
[GitHub] logging-log4j2 issue #120: LOG4J2-2091: Log4j respects the configured "log4j...
Posted by jvz <gi...@git.apache.org>.
Github user jvz commented on the issue:
https://github.com/apache/logging-log4j2/pull/120
Looks great, thanks! Anyone else on the team is welcome to merge this as I won't be around an appropriate computer until tomorrow at the earliest.
---