You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/02/05 10:12:16 UTC
[GitHub] [incubator-pekko-http] mdedetrich opened a new pull request, #34: Rename akka package to org.apache.pekko
mdedetrich opened a new pull request, #34:
URL: https://github.com/apache/incubator-pekko-http/pull/34
Draft, tbd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #34: Rename akka package to org.apache.pekko
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #34:
URL: https://github.com/apache/incubator-pekko-http/pull/34#issuecomment-1429581630
Issue regarding removed text created at https://github.com/apache/incubator-pekko-http/issues/42
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on a diff in pull request #34: Rename akka package to org.apache.pekko
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on code in PR #34:
URL: https://github.com/apache/incubator-pekko-http/pull/34#discussion_r1105536374
##########
docs/src/main/paradox/handling-blocking-operations-in-pekko-http-routes.md:
##########
@@ -66,7 +66,6 @@ For example, the above screenshot shows an Apache Pekko FJP dispatchers threads,
named "`default-akka.default-dispatcher2,3,4`" going into the blocking state, after having been idle.
It can be observed that the number of new threads increases, "`default-akka.actor.default-dispatcher 18,19,20,...`"
however they go to sleep state immediately, thus wasting the resources.
-@java[The same happens to the global @apidoc[ForkJoinPool] when using Java Futures.]
Review Comment:
Was that deleted intentionally? (Does not matter a lot)
##########
docs/src/test/scala/docs/http/scaladsl/Http2Spec.scala:
##########
@@ -4,31 +4,39 @@
package docs.http.scaladsl
-import akka.http.impl.util.ExampleHttpContexts
-import akka.http.scaladsl.model.{ HttpRequest, HttpResponse, StatusCodes }
+import org.apache.pekko
+import pekko.http.impl.util.ExampleHttpContexts
+import pekko.http.scaladsl.model.{ HttpRequest, HttpResponse, StatusCodes }
//#bindAndHandleSecure
import scala.concurrent.Future
-import akka.http.scaladsl.HttpsConnectionContext
//#bindAndHandleSecure
-//#http2ClientWithPriorKnowledge
-//#http2Client
//#bindAndHandleSecure
//#bindAndHandlePlain
-import akka.http.scaladsl.Http
+import org.apache.pekko
Review Comment:
The structure of the imports and how they are referenced into the docs seems to have changed here, was that intended?
##########
http-core/src/main/java/akka/http/javadsl/model/AttributeKeys.java:
##########
@@ -1,18 +0,0 @@
-/*
- * Copyright (C) 2019-2022 Lightbend Inc. <https://www.lightbend.com>
- */
-
-package akka.http.javadsl.model;
Review Comment:
For a bunch of those files, the changes seem to be big enough that git does not detect the move any more, I guess not a big problem in practice, though.
##########
http-core/src/main/java/akka/http/javadsl/model/AttributeKeys.java:
##########
@@ -1,18 +0,0 @@
-/*
- * Copyright (C) 2019-2022 Lightbend Inc. <https://www.lightbend.com>
- */
-
-package akka.http.javadsl.model;
Review Comment:
For `git diff` it seems adding the parameter `-M1` works (consider renamed when only 10% of the file are the same, instead of default 50%).
For `git blame` adding `-C` helps to get the original commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on a diff in pull request #34: Rename akka package to org.apache.pekko
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #34:
URL: https://github.com/apache/incubator-pekko-http/pull/34#discussion_r1105588305
##########
docs/src/main/paradox/handling-blocking-operations-in-pekko-http-routes.md:
##########
@@ -66,7 +66,6 @@ For example, the above screenshot shows an Apache Pekko FJP dispatchers threads,
named "`default-akka.default-dispatcher2,3,4`" going into the blocking state, after having been idle.
It can be observed that the number of new threads increases, "`default-akka.actor.default-dispatcher 18,19,20,...`"
however they go to sleep state immediately, thus wasting the resources.
-@java[The same happens to the global @apidoc[ForkJoinPool] when using Java Futures.]
Review Comment:
Ah damn, forgot to mention this. So basically I cannot get this to compile because even if I do a FQCN (i.e. `java.util.concurrent.ForkJoinPool`) but I noticed that both for current Akka and Pekko before this PR change it doesn't even render on the website so I just removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on pull request #34: Rename akka package to org.apache.pekko
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on PR #34:
URL: https://github.com/apache/incubator-pekko-http/pull/34#issuecomment-1418933075
> Although its possible to find which specific typesafe config settings refer specifically to the parent pekko core
That should be easy enough, every setting that does not start with `akka.http` would be referring to a core setting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on a diff in pull request #34: Rename akka package to org.apache.pekko
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on code in PR #34:
URL: https://github.com/apache/incubator-pekko-http/pull/34#discussion_r1105610044
##########
docs/src/main/paradox/handling-blocking-operations-in-pekko-http-routes.md:
##########
@@ -66,7 +66,6 @@ For example, the above screenshot shows an Apache Pekko FJP dispatchers threads,
named "`default-akka.default-dispatcher2,3,4`" going into the blocking state, after having been idle.
It can be observed that the number of new threads increases, "`default-akka.actor.default-dispatcher 18,19,20,...`"
however they go to sleep state immediately, thus wasting the resources.
-@java[The same happens to the global @apidoc[ForkJoinPool] when using Java Futures.]
Review Comment:
But, indeed, no need to fix it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich merged pull request #34: Rename akka package to org.apache.pekko
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #34:
URL: https://github.com/apache/incubator-pekko-http/pull/34
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on a diff in pull request #34: Rename akka package to org.apache.pekko
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #34:
URL: https://github.com/apache/incubator-pekko-http/pull/34#discussion_r1105588305
##########
docs/src/main/paradox/handling-blocking-operations-in-pekko-http-routes.md:
##########
@@ -66,7 +66,6 @@ For example, the above screenshot shows an Apache Pekko FJP dispatchers threads,
named "`default-akka.default-dispatcher2,3,4`" going into the blocking state, after having been idle.
It can be observed that the number of new threads increases, "`default-akka.actor.default-dispatcher 18,19,20,...`"
however they go to sleep state immediately, thus wasting the resources.
-@java[The same happens to the global @apidoc[ForkJoinPool] when using Java Futures.]
Review Comment:
Ah damn, forgot to mention this. So basically I cannot get this to compile because beforehand due to some shadowing rules it was picking up `akka.dispatch.forkjoin.ForkJoinPool` and when I tried changing this to a FQCN (i.e. `java.util.concurrent.ForkJoinPool`) as part of this PR it didn't compile however I noticed that both for current Akka and Pekko before this PR change it doesn't even render on the website so I just removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on pull request #34: Rename akka package to org.apache.pekko
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on PR #34:
URL: https://github.com/apache/incubator-pekko-http/pull/34#issuecomment-1429390910
Cool, will have a look now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #34: Rename akka package to org.apache.pekko
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #34:
URL: https://github.com/apache/incubator-pekko-http/pull/34#issuecomment-1429546656
Okay so I am going to go ahead and merge this, will also make an issue regarding https://github.com/apache/incubator-pekko-http/pull/34#discussion_r1105536374
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #34: Rename akka package to org.apache.pekko
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #34:
URL: https://github.com/apache/incubator-pekko-http/pull/34#issuecomment-1419075839
So good news, tests are finally passing. There are still a couple of things I need to double check, i.e. that the `import` statements in paradox are nicely formatted and some tests seem to produce a large amount of logs (which could indicate that the log silencing isn't working in some cases but it can also be the case that it was like this originally).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on a diff in pull request #34: Rename akka package to org.apache.pekko
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #34:
URL: https://github.com/apache/incubator-pekko-http/pull/34#discussion_r1105588305
##########
docs/src/main/paradox/handling-blocking-operations-in-pekko-http-routes.md:
##########
@@ -66,7 +66,6 @@ For example, the above screenshot shows an Apache Pekko FJP dispatchers threads,
named "`default-akka.default-dispatcher2,3,4`" going into the blocking state, after having been idle.
It can be observed that the number of new threads increases, "`default-akka.actor.default-dispatcher 18,19,20,...`"
however they go to sleep state immediately, thus wasting the resources.
-@java[The same happens to the global @apidoc[ForkJoinPool] when using Java Futures.]
Review Comment:
Ah damn, forgot to mention this. So basically I cannot get this to compile because beforehand due to some shadowing rules it was picking up `akka.dispatch.forkjoin.ForkJoinPool` and when I tried changing this to a FQCN (i.e. `java.util.concurrent.ForkJoinPool`) it didn't compile however I noticed that both for current Akka and Pekko before this PR change it doesn't even render on the website so I just removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on a diff in pull request #34: Rename akka package to org.apache.pekko
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #34:
URL: https://github.com/apache/incubator-pekko-http/pull/34#discussion_r1105623863
##########
docs/src/main/paradox/handling-blocking-operations-in-pekko-http-routes.md:
##########
@@ -66,7 +66,6 @@ For example, the above screenshot shows an Apache Pekko FJP dispatchers threads,
named "`default-akka.default-dispatcher2,3,4`" going into the blocking state, after having been idle.
It can be observed that the number of new threads increases, "`default-akka.actor.default-dispatcher 18,19,20,...`"
however they go to sleep state immediately, thus wasting the resources.
-@java[The same happens to the global @apidoc[ForkJoinPool] when using Java Futures.]
Review Comment:
> In case it is not clear, the `@java` block would only show if `Java` is selected in the nav bar.
Ah I see, but yes I will make an issue on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #34: Rename akka package to org.apache.pekko
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #34:
URL: https://github.com/apache/incubator-pekko-http/pull/34#issuecomment-1418925156
Thanks for finding this out, indeed the issue is that some configuration in pekko core has changed from `akka` to `pekko`. Although its possible to find which specific typesafe config settings refer specifically to the parent pekko core, I think it will be easier/safer/clearer to also do all of the configuration changes in a separate commit in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on pull request #34: Rename akka package to org.apache.pekko
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on PR #34:
URL: https://github.com/apache/incubator-pekko-http/pull/34#issuecomment-1418919226
> If there is anything on the top of your head that comes to mind let me know, otherwise I will have another look at this later in the week.
The event filters rely on `pekko.loggers` being set correctly, but settings have not yet been changed to use the `pekko` prefix yet. In this case, the problem is in `AkkaSpecWithMaterializer`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #34: Rename akka package to org.apache.pekko
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #34:
URL: https://github.com/apache/incubator-pekko-http/pull/34#issuecomment-1427708410
PR is now ready to review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #34: Rename akka package to org.apache.pekko
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #34:
URL: https://github.com/apache/incubator-pekko-http/pull/34#issuecomment-1418831630
@jrudolph I have done most of the work in regards to the package name change however I am now encountering an issue where any test that uses `org.apache.pekko.testkit.EventFilter` along with `org.apache.pekko.testkit.TestEvent.intercept` is failing. I have dune a cursory look through the code and couldn't find anything that would hint as to why its not working (i.e. I can't find any kind of hardcoded checking for the `akka` package).
If there is anything on the top of your head that comes to mind let me know, otherwise I will have another look at this later in the week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #34: Rename akka package to org.apache.pekko
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #34:
URL: https://github.com/apache/incubator-pekko-http/pull/34#issuecomment-1427754514
Will wait for @jrudolph , specifically for comments around `AkkaBuild`/`PekkoBuild`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning commented on a diff in pull request #34: Rename akka package to org.apache.pekko
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #34:
URL: https://github.com/apache/incubator-pekko-http/pull/34#discussion_r1105592467
##########
docs/src/main/paradox/handling-blocking-operations-in-pekko-http-routes.md:
##########
@@ -66,7 +66,6 @@ For example, the above screenshot shows an Apache Pekko FJP dispatchers threads,
named "`default-akka.default-dispatcher2,3,4`" going into the blocking state, after having been idle.
It can be observed that the number of new threads increases, "`default-akka.actor.default-dispatcher 18,19,20,...`"
however they go to sleep state immediately, thus wasting the resources.
-@java[The same happens to the global @apidoc[ForkJoinPool] when using Java Futures.]
Review Comment:
maybe, just add a Github issue to revisit this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on a diff in pull request #34: Rename akka package to org.apache.pekko
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #34:
URL: https://github.com/apache/incubator-pekko-http/pull/34#discussion_r1105593280
##########
docs/src/main/paradox/handling-blocking-operations-in-pekko-http-routes.md:
##########
@@ -66,7 +66,6 @@ For example, the above screenshot shows an Apache Pekko FJP dispatchers threads,
named "`default-akka.default-dispatcher2,3,4`" going into the blocking state, after having been idle.
It can be observed that the number of new threads increases, "`default-akka.actor.default-dispatcher 18,19,20,...`"
however they go to sleep state immediately, thus wasting the resources.
-@java[The same happens to the global @apidoc[ForkJoinPool] when using Java Futures.]
Review Comment:
Sure, can do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on a diff in pull request #34: Rename akka package to org.apache.pekko
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on code in PR #34:
URL: https://github.com/apache/incubator-pekko-http/pull/34#discussion_r1105609490
##########
docs/src/main/paradox/handling-blocking-operations-in-pekko-http-routes.md:
##########
@@ -66,7 +66,6 @@ For example, the above screenshot shows an Apache Pekko FJP dispatchers threads,
named "`default-akka.default-dispatcher2,3,4`" going into the blocking state, after having been idle.
It can be observed that the number of new threads increases, "`default-akka.actor.default-dispatcher 18,19,20,...`"
however they go to sleep state immediately, thus wasting the resources.
-@java[The same happens to the global @apidoc[ForkJoinPool] when using Java Futures.]
Review Comment:
In case it is not clear, the `@java` block would only show if `Java` is selected in the nav bar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #34: Rename akka package to org.apache.pekko
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #34:
URL: https://github.com/apache/incubator-pekko-http/pull/34#issuecomment-1429503052
> The only significant to `PekkoDependency` is the change of the default, isn't it? And that sounds somewhat reasonable for now (it might become a bit inefficient for development if we automatically choose a new nightly every day and invalidate sbt caches on our machines, but if that becomes a problem we could also fix on a certain version for the time being).
Yes this is correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on a diff in pull request #34: Rename akka package to org.apache.pekko
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #34:
URL: https://github.com/apache/incubator-pekko-http/pull/34#discussion_r1105588999
##########
docs/src/test/scala/docs/http/scaladsl/Http2Spec.scala:
##########
@@ -4,31 +4,39 @@
package docs.http.scaladsl
-import akka.http.impl.util.ExampleHttpContexts
-import akka.http.scaladsl.model.{ HttpRequest, HttpResponse, StatusCodes }
+import org.apache.pekko
+import pekko.http.impl.util.ExampleHttpContexts
+import pekko.http.scaladsl.model.{ HttpRequest, HttpResponse, StatusCodes }
//#bindAndHandleSecure
import scala.concurrent.Future
-import akka.http.scaladsl.HttpsConnectionContext
//#bindAndHandleSecure
-//#http2ClientWithPriorKnowledge
-//#http2Client
//#bindAndHandleSecure
//#bindAndHandlePlain
-import akka.http.scaladsl.Http
+import org.apache.pekko
Review Comment:
Yes, if you check the rendered docs with `sbt paradox` you can see why I need to change the imports statements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on a diff in pull request #34: Rename akka package to org.apache.pekko
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #34:
URL: https://github.com/apache/incubator-pekko-http/pull/34#discussion_r1105593280
##########
docs/src/main/paradox/handling-blocking-operations-in-pekko-http-routes.md:
##########
@@ -66,7 +66,6 @@ For example, the above screenshot shows an Apache Pekko FJP dispatchers threads,
named "`default-akka.default-dispatcher2,3,4`" going into the blocking state, after having been idle.
It can be observed that the number of new threads increases, "`default-akka.actor.default-dispatcher 18,19,20,...`"
however they go to sleep state immediately, thus wasting the resources.
-@java[The same happens to the global @apidoc[ForkJoinPool] when using Java Futures.]
Review Comment:
Sure, can do, will do it after PR merge so I can point the issue to correct part of code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org