You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "Fine0830 (via GitHub)" <gi...@apache.org> on 2024/03/11 04:06:43 UTC
[PR] Fix console warnings in dev mod, and optimize `vite` configuration for proxy, and remove unused codes [skywalking-banyandb]
Fine0830 opened a new pull request, #408:
URL: https://github.com/apache/skywalking-banyandb/pull/408
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes apache/skywalking#<issue number>.
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking-banyandb/blob/main/CHANGES.md).
Video
https://github.com/apache/skywalking-banyandb/assets/20871783/106713ea-6a70-4124-b63d-8a524324c507
Signed-off-by: Qiuxia Fan <qi...@apache.org>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix console warnings in dev mod, and optimize `vite` configuration for proxy, and remove unused codes [skywalking-banyandb]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #408:
URL: https://github.com/apache/skywalking-banyandb/pull/408#issuecomment-1987604405
## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/408?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 48.13%. Comparing base [(`b4fb8ff`)](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/b4fb8ff36ef6650ada8846c04a62735cdaa52391?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`63a68c5`)](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/408?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #408 +/- ##
==========================================
- Coverage 48.57% 48.13% -0.45%
==========================================
Files 173 173
Lines 21592 21592
==========================================
- Hits 10489 10393 -96
- Misses 10204 10314 +110
+ Partials 899 885 -14
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/408?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix console warnings in dev mod, and optimize `vite` configuration for proxy, and remove unused codes [skywalking-banyandb]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #408:
URL: https://github.com/apache/skywalking-banyandb/pull/408
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix console warnings in dev mod, and optimize `vite` configuration for proxy, and remove unused codes [skywalking-banyandb]
Posted by "Fine0830 (via GitHub)" <gi...@apache.org>.
Fine0830 commented on PR #408:
URL: https://github.com/apache/skywalking-banyandb/pull/408#issuecomment-1990962300
This configuration is aimed at preventing accidental exposure of sensitive configuration settings every time the `Vite` configuration is modified. Now, you only need to add a script named `.env.local` in the project, where you place the address to be proxied. For example, VITE_API_PROXY_TARGET = http://baidu.com/. Refer to https://vitejs.dev/guide/env-and-mode.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix console warnings in dev mod, and optimize `vite` configuration for proxy, and remove unused codes [skywalking-banyandb]
Posted by "Sylvie-Wxr (via GitHub)" <gi...@apache.org>.
Sylvie-Wxr commented on PR #408:
URL: https://github.com/apache/skywalking-banyandb/pull/408#issuecomment-1990948027
Hi @Fine0830 , this is Sylvie, a student developer wishes to contribute to BanyanDB during GSOC. Nice to meet you~ I wish to ask you about the vite.config.js in this PR.
After this change, in local development of ui, we have to manually add VITE_API_PROXY_TARGET and VITE_MONITOR_PROXY_TARGET to env variables . Is this intended?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org