You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by tr...@apache.org on 2019/05/23 16:18:42 UTC

[flink] 02/08: [hotfix][network, tests] Add new unit tests for PartitionRequestServerHandler

This is an automated email from the ASF dual-hosted git repository.

trohrmann pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git

commit f78e494cb4710c916e3e7bee32c792d42f243bb2
Author: Zhijiang <wa...@aliyun.com>
AuthorDate: Wed May 15 17:36:32 2019 +0800

    [hotfix][network,tests] Add new unit tests for PartitionRequestServerHandler
    
    It is necessary to make sure the network server would not transform or swallow the PartitionNotFoundException thrown by ResultPartitionManager, so a new unit test
    is added for PartitionReuqestServerHandler to cover this case.
---
 .../netty/PartitionRequestServerHandlerTest.java   | 71 ++++++++++++++++++++++
 1 file changed, 71 insertions(+)

diff --git a/flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestServerHandlerTest.java b/flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestServerHandlerTest.java
new file mode 100644
index 0000000..23f2254
--- /dev/null
+++ b/flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestServerHandlerTest.java
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.io.network.netty;
+
+import org.apache.flink.runtime.io.network.TaskEventDispatcher;
+import org.apache.flink.runtime.io.network.netty.NettyMessage.ErrorResponse;
+import org.apache.flink.runtime.io.network.netty.NettyMessage.PartitionRequest;
+import org.apache.flink.runtime.io.network.partition.PartitionNotFoundException;
+import org.apache.flink.runtime.io.network.partition.ResultPartitionID;
+import org.apache.flink.runtime.io.network.partition.ResultPartitionManager;
+import org.apache.flink.runtime.io.network.partition.consumer.InputChannelID;
+import org.apache.flink.util.TestLogger;
+
+import org.apache.flink.shaded.netty4.io.netty.channel.embedded.EmbeddedChannel;
+
+import org.junit.Test;
+
+import static org.hamcrest.Matchers.instanceOf;
+import static org.hamcrest.Matchers.is;
+import static org.junit.Assert.assertThat;
+
+/**
+ * Tests for {@link PartitionRequestServerHandler}.
+ */
+public class PartitionRequestServerHandlerTest extends TestLogger {
+
+	/**
+	 * Tests that {@link PartitionRequestServerHandler} responds {@link ErrorResponse} with wrapped
+	 * {@link PartitionNotFoundException} after receiving invalid {@link PartitionRequest}.
+	 */
+	@Test
+	public void testResponsePartitionNotFoundException() {
+		final PartitionRequestServerHandler serverHandler = new PartitionRequestServerHandler(
+			new ResultPartitionManager(),
+			new TaskEventDispatcher(),
+			new PartitionRequestQueue(),
+			true);
+		final EmbeddedChannel channel = new EmbeddedChannel(serverHandler);
+		final ResultPartitionID partitionId = new ResultPartitionID();
+
+		// Write the message of partition request to server
+		channel.writeInbound(new PartitionRequest(partitionId, 0, new InputChannelID(), 2));
+		channel.runPendingTasks();
+
+		// Read the response message after handling partition request
+		final Object msg = channel.readOutbound();
+		assertThat(msg, instanceOf(ErrorResponse.class));
+
+		final ErrorResponse err = (ErrorResponse) msg;
+		assertThat(err.cause, instanceOf(PartitionNotFoundException.class));
+
+		final ResultPartitionID actualPartitionId = ((PartitionNotFoundException) err.cause).getPartitionId();
+		assertThat(partitionId, is(actualPartitionId));
+	}
+}