You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "mumrah (via GitHub)" <gi...@apache.org> on 2024/09/18 14:15:40 UTC
[PR] MINOR Fix is-public-fork input type [kafka]
mumrah opened a new pull request, #17227:
URL: https://github.com/apache/kafka/pull/17227
PRs are getting the wrong value for this workflow input. The context value we are checking is a boolean and we were treating it as a string. This patch fixes that by defining the workflow input as a boolean and treating it as such.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR Fix is-public-fork input type [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah commented on PR #17227:
URL: https://github.com/apache/kafka/pull/17227#issuecomment-2361752554
@chia7712 I updated the inputs as suggested. Note that composite actions do not support input types (everything is a string I think). See https://github.com/actions/runner/issues/2238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR Fix is-public-fork input type [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah merged PR #17227:
URL: https://github.com/apache/kafka/pull/17227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR Fix is-public-fork input type [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #17227:
URL: https://github.com/apache/kafka/pull/17227#issuecomment-2361795817
> Note that composite actions do not support input types (everything is a string I think). See https://github.com/actions/runner/issues/2238
thanks for this sharing. I have noted it. BTW, could you please add comment to those composite file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org