[GitHub] [beam] apilloud commented on a diff in pull request #17446: [BEAM-14356] fixing a postcommit test

[GitBox <gi...@apache.org>]

apilloud commented on code in PR #17446:
URL: https://github.com/apache/beam/pull/17446#discussion_r856510214


##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOJsonIT.java:
##########
@@ -65,7 +66,13 @@
 public class BigQueryIOJsonIT {
   private static final Logger LOG = LoggerFactory.getLogger(BigQueryIOJsonIT.class);
 
-  @Rule public final transient TestPipeline p = TestPipeline.create();
+  private static PipelineOptions testOptions = TestPipeline.testingPipelineOptions();
+
+  static {
+    testOptions.setTempLocation("gs://bigqueryio-json-it-temp/java-tmp");

Review Comment:
   How do you expect this test to run for those who don't have access to `gs://bigqueryio-json-it-temp`? We have a bunch of tests that do something like `options.setTempLocation(options.getTempRoot() + "/java-tmp");` can you do something like that?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org