[GitHub] [spark] gaborgsomogyi commented on a change in pull request #24804: [SPARK-23472][CORE] Add defaultJavaOptions for driver and executor.

[GitBox <gi...@apache.org>]

gaborgsomogyi commented on a change in pull request #24804: [SPARK-23472][CORE] Add defaultJavaOptions for driver and executor.
URL: https://github.com/apache/spark/pull/24804#discussion_r297658344
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
 ##########
 @@ -51,8 +51,16 @@ package object config {
   private[spark] val DRIVER_CLASS_PATH =
     ConfigBuilder(SparkLauncher.DRIVER_EXTRA_CLASSPATH).stringConf.createOptional
 
+  private[spark] val DRIVER_DEFAULT_JAVA_OPTIONS =
 
 Review comment:
   Thought would be good to have it because users can see the structure (string, optional, etc) but I've removed it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org