You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/05/11 04:28:23 UTC
[GitHub] [incubator-dolphinscheduler] simon824 opened a new pull request #2669: add unique key for t_ds_process_definition
simon824 opened a new pull request #2669:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2669
add unique key for t_ds_process_definition
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] codecov-io commented on pull request #2669: add unique key for t_ds_process_definition
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #2669:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2669#issuecomment-626470540
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2669?src=pr&el=h1) Report
> Merging [#2669](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2669?src=pr&el=desc) into [dev-1.3.0](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/db772438a26b8ee8b61a17d17421c4e3b2511f29&el=desc) will **increase** coverage by `0.54%`.
> The diff coverage is `66.12%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2669?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev-1.3.0 #2669 +/- ##
===============================================
+ Coverage 36.45% 37.00% +0.54%
- Complexity 2490 2528 +38
===============================================
Files 431 431
Lines 19878 19856 -22
Branches 2424 2419 -5
===============================================
+ Hits 7246 7347 +101
+ Misses 11977 11841 -136
- Partials 655 668 +13
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2669?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...cheduler/api/controller/WorkerGroupController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2669/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvV29ya2VyR3JvdXBDb250cm9sbGVyLmphdmE=) | `18.18% <ø> (+7.65%)` | `2.00 <0.00> (ø)` | |
| [...nscheduler/api/service/ProcessInstanceService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2669/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUHJvY2Vzc0luc3RhbmNlU2VydmljZS5qYXZh) | `78.16% <ø> (ø)` | `33.00 <0.00> (ø)` | |
| [...pache/dolphinscheduler/dao/entity/WorkerGroup.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2669/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9Xb3JrZXJHcm91cC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...e/dolphinscheduler/server/worker/WorkerServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2669/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9Xb3JrZXJTZXJ2ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../server/worker/processor/TaskExecuteProcessor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2669/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9wcm9jZXNzb3IvVGFza0V4ZWN1dGVQcm9jZXNzb3IuamF2YQ==) | `36.66% <0.00%> (+25.95%)` | `3.00 <0.00> (+2.00)` | |
| [...eduler/server/worker/runner/TaskExecuteThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2669/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9ydW5uZXIvVGFza0V4ZWN1dGVUaHJlYWQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lphinscheduler/service/process/ProcessService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2669/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvcHJvY2Vzcy9Qcm9jZXNzU2VydmljZS5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...lphinscheduler/api/service/WorkerGroupService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2669/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvV29ya2VyR3JvdXBTZXJ2aWNlLmphdmE=) | `82.69% <78.78%> (+2.98%)` | `8.00 <3.00> (-5.00)` | :arrow_up: |
| [...cheduler/api/service/ProcessDefinitionService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2669/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUHJvY2Vzc0RlZmluaXRpb25TZXJ2aWNlLmphdmE=) | `60.84% <100.00%> (-9.52%)` | `75.00 <0.00> (-17.00)` | |
| ... and [19 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2669/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2669?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2669?src=pr&el=footer). Last update [db77243...5c38f6d](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2669?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org