You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "michael-o (via GitHub)" <gi...@apache.org> on 2024/05/12 10:11:23 UTC

[PR] Bump Maven Site Plugin AND Maven Fluido Skin [maven-site]

michael-o opened a new pull request, #525:
URL: https://github.com/apache/maven-site/pull/525

   Both need to be updated in tandem to get proper rendering results.
   
   Addresses one of the issues from https://the-asf.slack.com/archives/C7Q9JB404/p1715479275966359


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump Maven Site Plugin AND Maven Fluido Skin [maven-site]

Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on PR #525:
URL: https://github.com/apache/maven-site/pull/525#issuecomment-2471243520

   If there is no further concerns, I am gonna merge tomorrow. The table column alignment has been meanwhile clarified in https://issues.apache.org/jira/browse/MSKINS-230.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump Maven Site Plugin AND Maven Fluido Skin [maven-site]

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #525:
URL: https://github.com/apache/maven-site/pull/525#issuecomment-2456543626

   > I think it is time for an update again. @michael-o Do you take it up or should I take over to bump to latest m-site-p and fluido 2?
   
   Let me finish Fluido release today first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump Maven Site Plugin AND Maven Fluido Skin [maven-site]

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #525:
URL: https://github.com/apache/maven-site/pull/525#issuecomment-2106949922

   > I have not deliberately changed anything about being more strict with section nesting, I think we should still allow starting with an h2. Could be an unintended side effect of fixing the nesting levels. Do we have a minimum example in MD? Any warning emitted?
   
   Minimal MD without any output and broken HTML:
   ```
   ## Introduction
   
   Foo
   ```
   output:
   ```ยด
           <main id="bodyColumn" class="span10">
   <section>
           </main>
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump Maven Site Plugin AND Maven Fluido Skin [maven-site]

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #525:
URL: https://github.com/apache/maven-site/pull/525#issuecomment-2106219203

   > We should check it ... by other hands My test:
   > 
   >     * `What is Maven?`, `Maven Extensions` - is empty - markdown problems?
   > 
   >     * `Release Notes` - is almost empty - looks like macros not working
   > 
   > 
   > I not checked all pages ๐Ÿ˜„
   
   It is broken, the parsers are strict now for sections:
   ```patch
   D:\Entwicklung\Projekte\maven-site [bump-site-and-fluido-version โ‰ก +0 ~2 -0 !]> git diff content/markdown/what-is-maven.md
   diff --git a/content/markdown/what-is-maven.md b/content/markdown/what-is-maven.md
   index 9a8f73d4..bb848972 100644
   --- a/content/markdown/what-is-maven.md
   +++ b/content/markdown/what-is-maven.md
   @@ -1,4 +1,4 @@
   -## Introduction
   +# Introduction
    <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump Maven Site Plugin AND Maven Fluido Skin [maven-site]

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #525:
URL: https://github.com/apache/maven-site/pull/525#issuecomment-2106353225

   > release history: <img alt="image" width="1412" src="https://private-user-images.githubusercontent.com/3578921/329851510-76c2c23e-53cd-4ee0-9fc7-7bc695c8bbb3.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTU1NDE0MDgsIm5iZiI6MTcxNTU0MTEwOCwicGF0aCI6Ii8zNTc4OTIxLzMyOTg1MTUxMC03NmMyYzIzZS01M2NkLTRlZTAtOWZjNy03YmM2OTVjOGJiYjMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDUxMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA1MTJUMTkxMTQ4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YjExMWM4ZjU0MWMyMmFhNzMzYjk2ZGZiNTNjODYwY2FmN2NmODYzNDAxZTExYzI1OTc3ZDljZGIxNzUyNTM3YiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.uF8lYoXangFAQq2bHYGICwRJVCEl1mfctxs_5JjQVgI">
   
   Done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump Maven Site Plugin AND Maven Fluido Skin [maven-site]

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #525:
URL: https://github.com/apache/maven-site/pull/525#issuecomment-2106353685

   > > It is broken, the parsers are strict now for sections:
   > 
   > So the build should fail when page is not generated at all due to error.
   
   From the top of my head I have no idea because this is now only with Markdown and most of the parsing is done with Flexmark anyway. But some of the strictness has been added by @kwin recently. The purpose is that the output should be parseable again from a Doxia point of view. Broken output cannot be parsed :-(


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump Maven Site Plugin AND Maven Fluido Skin [maven-site]

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #525:
URL: https://github.com/apache/maven-site/pull/525#issuecomment-2106351824

   > > It is broken, the parsers are strict now for sections:
   > 
   > So the build should fail when page is not generated at all due to error.
   
   @kwin, WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump Maven Site Plugin AND Maven Fluido Skin [maven-site]

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #525:
URL: https://github.com/apache/maven-site/pull/525#issuecomment-2106925147

   I have found another severe bug I need to report: As soon as auto anchors are enabled title for the document is not extracted/filled, if you do this then it works again:
   ```
   diff --git a/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java b/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java
   index 544b6b9..b6a7d1d 100644
   --- a/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java
   +++ b/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java
   @@ -330,7 +330,6 @@ public class DefaultSiteRenderer implements Renderer {
                if (!isConfigured) {
                    // DOXIASITETOOLS-146 don't render comments from source markup
                    parser.setEmitComments(false);
   -                parser.setEmitAnchorsForIndexableEntries(true);
                }
   
                // TODO: DOXIA-111: the filter used here must be checked generally.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump Maven Site Plugin AND Maven Fluido Skin [maven-site]

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #525:
URL: https://github.com/apache/maven-site/pull/525#issuecomment-2106240810

   alignment also changed:
   <img width="1475" alt="image" src="https://github.com/apache/maven-site/assets/3578921/e46b6c30-1083-41a6-91d1-461197969493">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump Maven Site Plugin AND Maven Fluido Skin [maven-site]

Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on PR #525:
URL: https://github.com/apache/maven-site/pull/525#issuecomment-2462790180

   > lost anchors with toc at https://maven.apache.org/settings.html
   
   The anchor format changed (using uppercase), unfortunately https://github.com/apache/maven-site/blob/e225ba9c417830bea36e03285ec52f8330790d07/content/markdown/settings.md?plain=1#L20 uses no macro but a hardcoded list and relies on implementation details of the anchor format.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump Maven Site Plugin AND Maven Fluido Skin [maven-site]

Posted by "ditbace (via GitHub)" <gi...@apache.org>.
ditbace commented on PR #525:
URL: https://github.com/apache/maven-site/pull/525#issuecomment-2457214109

   sure thank you
   
   On Tue, Nov 5, 2024 at 3:35โ€ฏAM Michael Osipov ***@***.***>
   wrote:
   
   > I think it is time for an update again. @michael-o
   > <https://github.com/michael-o> Do you take it up or should I take over to
   > bump to latest m-site-p and fluido 2?
   >
   > Let me finish Fluido release today first.
   >
   > โ€”
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/maven-site/pull/525#issuecomment-2456543626>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/A3RYIUKKA6HWWP26VOWYAULZ7B7LHAVCNFSM6AAAAABHSV3YC2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJWGU2DGNRSGY>
   > .
   > You are receiving this because you are subscribed to this thread.Message
   > ID: ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump Maven Site Plugin AND Maven Fluido Skin [maven-site]

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #525:
URL: https://github.com/apache/maven-site/pull/525#issuecomment-2106223558

   @slawekjaranowski This should fix it. The Markdown files were logically incorrect.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump Maven Site Plugin AND Maven Fluido Skin [maven-site]

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #525:
URL: https://github.com/apache/maven-site/pull/525#issuecomment-2106219738

   > We should check it ... by other hands My test:
   > 
   >     * `What is Maven?`, `Maven Extensions` - is empty - markdown problems?
   > 
   >     * `Release Notes` - is almost empty - looks like macros not working
   > 
   > 
   > I not checked all pages ๐Ÿ˜„
   
   Which release notes are empty?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump Maven Site Plugin AND Maven Fluido Skin [maven-site]

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #525:
URL: https://github.com/apache/maven-site/pull/525#issuecomment-2471618906

   > If there is no further concerns, I am gonna merge tomorrow. The table column alignment has been meanwhile clarified in https://issues.apache.org/jira/browse/MSKINS-230.
   
   Go ahead 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump Maven Site Plugin AND Maven Fluido Skin [maven-site]

Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on PR #525:
URL: https://github.com/apache/maven-site/pull/525#issuecomment-2456412408

   I think it is time for an update again. @michael-o Do you take it up or should I take over to bump to latest m-site-p and fluido 2?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump Maven Site Plugin AND Maven Fluido Skin [maven-site]

Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin merged PR #525:
URL: https://github.com/apache/maven-site/pull/525


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump Maven Site Plugin AND Maven Fluido Skin [maven-site]

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #525:
URL: https://github.com/apache/maven-site/pull/525#issuecomment-2106240343

   > 
   > It is broken, the parsers are strict now for sections:
   >
   
   So the build should fail when page is not generated at all due to error.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump Maven Site Plugin AND Maven Fluido Skin [maven-site]

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #525:
URL: https://github.com/apache/maven-site/pull/525#issuecomment-2106353179

   > alignment also changed: <img alt="image" width="1475" src="https://private-user-images.githubusercontent.com/3578921/329851741-e46b6c30-1083-41a6-91d1-461197969493.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTU1NDE0MDgsIm5iZiI6MTcxNTU0MTEwOCwicGF0aCI6Ii8zNTc4OTIxLzMyOTg1MTc0MS1lNDZiNmMzMC0xMDgzLTQxYTYtOTFkMS00NjExOTc5Njk0OTMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDUxMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA1MTJUMTkxMTQ4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MjM4ODNkYThmM2IxZDhiMGQxYWM5NzRhMTA5N2Q4MjU1NWU5YWFiMjA3MjVmMzk2NWYzMjhjZmM2NWM3MzljYSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.FiQxmCs67onCsQxcvLCgf5M1XTpa0K_hIXcLzvO1kGQ">
   
   Comes from https://issues.apache.org/jira/browse/MSKINS-230. We need to decide whether we want to keep it it have bootstrap style enforced.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump Maven Site Plugin AND Maven Fluido Skin [maven-site]

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #525:
URL: https://github.com/apache/maven-site/pull/525#issuecomment-2457899285

   @kwin skin is on Central, you can upgrade this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump Maven Site Plugin AND Maven Fluido Skin [maven-site]

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #525:
URL: https://github.com/apache/maven-site/pull/525#issuecomment-2106910860

   > I have not deliberately changed anything about being more strict with section nesting, I think we should still allow starting with an h2. Could be an unintended side effect of fixing the nesting levels. Do we have a minimum example in MD? Any warning emitted?
   
   There is no warning, just no output.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump Maven Site Plugin AND Maven Fluido Skin [maven-site]

Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on PR #525:
URL: https://github.com/apache/maven-site/pull/525#issuecomment-2106355412

   I have not deliberately changed anything about being more strict with section nesting, I think we should still allow starting with an h2. Could be an unintended side effect of fixing the nesting levels. Do we have a minimum example in MD? Any warning emitted?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump Maven Site Plugin AND Maven Fluido Skin [maven-site]

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #525:
URL: https://github.com/apache/maven-site/pull/525#issuecomment-2106995637

   I will factor out the document fixes first...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump Maven Site Plugin AND Maven Fluido Skin [maven-site]

Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on PR #525:
URL: https://github.com/apache/maven-site/pull/525#issuecomment-2462751426

   Ok found one regression with table headers, they are by default centered and no longer left-aligned: 
   
   ![Screenshot 2024-11-07 at 17 47 51](https://github.com/user-attachments/assets/1af5b7ef-b301-42fc-869e-48b31d4d6776)
   
   This seems to have regressed with https://github.com/apache/maven-fluido-skin/commit/85123d7be9f42c98712ff94e18619095ab284a9f. @michael-o Any idea?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump Maven Site Plugin AND Maven Fluido Skin [maven-site]

Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on PR #525:
URL: https://github.com/apache/maven-site/pull/525#issuecomment-2462555731

   I just did, pushed the updated and cross-checked the result. Looks good to me. @slawekjaranowski Would you mind having another look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump Maven Site Plugin AND Maven Fluido Skin [maven-site]

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #525:
URL: https://github.com/apache/maven-site/pull/525#issuecomment-2106239721

   release history:
   <img width="1412" alt="image" src="https://github.com/apache/maven-site/assets/3578921/76c2c23e-53cd-4ee0-9fc7-7bc695c8bbb3">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump Maven Site Plugin AND Maven Fluido Skin [maven-site]

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #525:
URL: https://github.com/apache/maven-site/pull/525#issuecomment-2106933024

   Here it is https://issues.apache.org/jira/browse/DOXIASITETOOLS-339


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump Maven Site Plugin AND Maven Fluido Skin [maven-site]

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #525:
URL: https://github.com/apache/maven-site/pull/525#issuecomment-2106937721

   I will hold off new releases until this issues is resolved.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump Maven Site Plugin AND Maven Fluido Skin [maven-site]

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #525:
URL: https://github.com/apache/maven-site/pull/525#issuecomment-2106199112

   We should check it ... by other hands
   My test:
    - `What is Maven?`, `Maven Extensions` - is empty - markdown problems?
    - `Release Notes` - is almost empty - looks like macros not working
    
   I not checked all pages ๐Ÿ˜„ 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org