You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ma...@apache.org on 2026/04/08 20:23:37 UTC
(superset) branch master updated: fix(frontend): fix loading spinner positioning in Save modal and filters panel (#39205)
This is an automated email from the ASF dual-hosted git repository.
maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new d63308ca372 fix(frontend): fix loading spinner positioning in Save modal and filters panel (#39205)
d63308ca372 is described below
commit d63308ca372c3d87c9ddf48e896c61623788f907
Author: Maxime Beauchemin <ma...@gmail.com>
AuthorDate: Wed Apr 8 13:23:30 2026 -0700
fix(frontend): fix loading spinner positioning in Save modal and filters panel (#39205)
Co-authored-by: Claude Opus 4.6 <no...@anthropic.com>
Co-authored-by: yousoph <so...@gmail.com>
---
.../components/nativeFilters/FilterBar/Vertical.tsx | 11 +++++++++--
.../src/explore/components/SaveModal.tsx | 19 +++++++++----------
2 files changed, 18 insertions(+), 12 deletions(-)
diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Vertical.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Vertical.tsx
index fa9ab3c4183..864db364a38 100644
--- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Vertical.tsx
+++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Vertical.tsx
@@ -288,8 +288,15 @@ const VerticalFilterBar: FC<VerticalBarProps> = ({
<Bar className={cx({ open: filtersOpen })} width={width}>
<Header toggleFiltersBar={toggleFiltersBar} />
{!isInitialized ? (
- <div css={{ height }}>
- <Loading size="s" muted />
+ <div
+ css={{
+ height,
+ display: 'flex',
+ alignItems: 'center',
+ justifyContent: 'center',
+ }}
+ >
+ <Loading position="inline-centered" size="s" muted />
</div>
) : (
<div css={tabPaneStyle} onScroll={onScroll}>
diff --git a/superset-frontend/src/explore/components/SaveModal.tsx b/superset-frontend/src/explore/components/SaveModal.tsx
old mode 100644
new mode 100755
index 5dff843dbbb..6e72769f078
--- a/superset-frontend/src/explore/components/SaveModal.tsx
+++ b/superset-frontend/src/explore/components/SaveModal.tsx
@@ -93,11 +93,6 @@ export const StyledModal = styled(Modal)`
.ant-modal-body {
overflow: visible;
}
- i {
- position: absolute;
- top: -${({ theme }) => theme.sizeUnit * 5.25}px;
- left: ${({ theme }) => theme.sizeUnit * 26.75}px;
- }
`;
class SaveModal extends Component<SaveModalProps, SaveModalState> {
@@ -172,17 +167,21 @@ class SaveModal extends Component<SaveModalProps, SaveModalState> {
this.setState({ newSliceName: event.target.value });
}
- onDashboardChange = async (dashboard: {
- label: string;
- value: string | number;
- }) => {
+ onDashboardChange = async (
+ dashboard:
+ | {
+ label: string;
+ value: string | number;
+ }
+ | undefined,
+ ) => {
this.setState({
dashboard,
tabsData: [],
selectedTab: undefined,
});
- if (typeof dashboard.value === 'number') {
+ if (dashboard && typeof dashboard.value === 'number') {
await this.loadTabs(dashboard.value);
}
};