You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by coderxiang <gi...@git.apache.org> on 2014/10/27 22:30:32 UTC
[GitHub] spark pull request: [MLlib] SPARK-3987: add test case on objective...
GitHub user coderxiang opened a pull request:
https://github.com/apache/spark/pull/2965
[MLlib] SPARK-3987: add test case on objective value for NNLS
Also update step parameter to pass the proposed test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/coderxiang/spark nnls-test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/2965.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2965
----
commit 24b06f9d43cedb48e024b793357737df949445f9
Author: coderxiang <sh...@gmail.com>
Date: 2014-10-27T21:25:24Z
add test case on objective value for NNLS; update step parameter to pass the test
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [MLlib] SPARK-3987: add test case on objective...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/2965#issuecomment-60702505
LGTM. Merged into both master and branch-1.1. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [MLlib] SPARK-3987: add test case on objective...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2965#issuecomment-60683282
[Test build #22309 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22309/consoleFull) for PR 2965 at commit [`24b06f9`](https://github.com/apache/spark/commit/24b06f9d43cedb48e024b793357737df949445f9).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `abstract class Broadcast[T: ClassTag](val id: Long) extends Serializable with Logging `
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [MLlib] SPARK-3987: add test case on objective...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2965#issuecomment-60683292
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22309/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [MLlib] SPARK-3987: add test case on objective...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2965#issuecomment-60673543
[Test build #22309 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22309/consoleFull) for PR 2965 at commit [`24b06f9`](https://github.com/apache/spark/commit/24b06f9d43cedb48e024b793357737df949445f9).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [MLlib] SPARK-3987: add test case on objective...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2965
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org