You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by "eolivelli (via GitHub)" <gi...@apache.org> on 2023/08/15 16:15:26 UTC

[GitHub] [pulsar] eolivelli commented on a diff in pull request #20902: [fix][io] Improve loading sensitive fields for many connectors

eolivelli commented on code in PR #20902:
URL: https://github.com/apache/pulsar/pull/20902#discussion_r1294832861


##########
pulsar-io/aerospike/pom.xml:
##########
@@ -38,6 +38,12 @@
       <version>${project.version}</version>
     </dependency>
 
+    <dependency>
+      <groupId>${project.groupId}</groupId>
+      <artifactId>pulsar-io-common</artifactId>
+      <version>${project.version}</version>

Review Comment:
   Connectors shouldn't bundle Pulsar IO jars.
   This must be scope 'provided'
   
   Are we breaking compatibility  with existing connectors?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org