[jira] [Closed] (THRIFT-4793) Drop PHP support for versions before 7.1

["James E. King III (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-4793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James E. King III closed THRIFT-4793.
-------------------------------------
    Resolution: Won't Do

Given we're not leveraging any new language features and there are no code changes, we'll leave it as-is.  We don't run any tests on php 5.5.  I was able to upgrade phpunit to {{^6}} and that worked.  When I upgraded it to the earliest supported version {{^7}} it forced php up to 7.1 which excluded xenial.  That's not necessarily a bad thing since php 7.0 os EOL/EOS and no more security updates from php team, but I assume the xenial LTS still has to support it until 2021 somehow.  Anyway it wasn't worth the effort to make a change without a corresponding code change that requires the update.

> Drop PHP support for versions before 7.1
> ----------------------------------------
>
>                 Key: THRIFT-4793
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4793
>             Project: Thrift
>          Issue Type: Improvement
>          Components: PHP - Library
>    Affects Versions: 0.12.0
>            Reporter: James E. King III
>            Assignee: James E. King III
>            Priority: Major
>              Labels: Breaking-Change
>
> Support for PHP 7.1 ended December 2018  Security support runs until DEC 2019.
> All PHP development should be on PHP 7.2 or later.
> phpunit version 8 is the current version and we're using 4.8.  phpunit8 requires PHP 7.2.
> phpunit7 requires php 7.1 and has fewer breaking changes.
> These changes will drop support for PHP < 7.1.  Ubuntu xenial build job will stop building php.
> Folks who need PHP support for versions before 7.1 can use version 0.12.0 which is already released.
> The code may actually work, but we should keep up with the ecosystem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)