[jira] [Commented] (FLINK-5425) JobManager replaced by IP in metrics

["Chesnay Schepler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-5425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15809906#comment-15809906 ] 

Chesnay Schepler commented on FLINK-5425:
-----------------------------------------

As far as I'm aware the Graphite reporter filters out "." and replace them with "-", see https://github.com/apache/flink/blob/master/flink-metrics/flink-metrics-dropwizard/src/main/java/org/apache/flink/dropwizard/ScheduledDropwizardReporter.java#L184, specifically to counter these situations. Is this not working for you?

I would prefer to we keep deferring these modifications of the metric name to the reporter since other systems may not require dots to be filtered out. Also, reporters have to apply these filters anyway; some other part of name may be containing a dot as well. This means that if the reporter has a problem with the ip containing dots then the reporter is broken in the first place.

Is this problem actually present in 1.1.3? I'm asking since the code you linked is part of FLIP-6 and was only merged recently; it is neither part of 1.1 or 1.2.
As a related question: Which taskmanager code did you look at, the current or FLIP-6 one?



> JobManager <host> replaced by IP in metrics
> -------------------------------------------
>
>                 Key: FLINK-5425
>                 URL: https://issues.apache.org/jira/browse/FLINK-5425
>             Project: Flink
>          Issue Type: Bug
>          Components: Metrics
>    Affects Versions: 1.1.3
>            Reporter: Shannon Carey
>            Priority: Minor
>
> In metrics at the jobmanager level and below, the "<host>" scope variable is being replaced by the IP rather than the hostname. The taskmanager metrics, meanwhile, use the host name.
> You can see the job manager behavior at https://github.com/apache/flink/blob/a1934255421b97eefd579183e9c7199c43ad1a2c/flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobManagerRunner.java#L147 compared to TaskManagerLocation#getHostname().
> The problem with this is mainly that due to the presence of "." (period) characters in the IP address and thereby the metric name, the metric names show up strangely in Graphite/Grafana, where "." is the metric group separator.
> If it's not possible to make jobmanager metrics use the hostname, I suggest replacing "." with "-" in the <host> section.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)