You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/03 18:54:15 UTC

[GitHub] [superset] willbarrett commented on a change in pull request #13440: docs: deprecate old alerts and dash/charts reports

willbarrett commented on a change in pull request #13440:
URL: https://github.com/apache/superset/pull/13440#discussion_r586694751



##########
File path: superset/config.py
##########
@@ -614,18 +615,8 @@ class CeleryConfig:  # pylint: disable=too-few-public-methods
     CELERY_ACKS_LATE = False
     CELERY_ANNOTATIONS = {
         "sql_lab.get_sql_results": {"rate_limit": "100/s"},

Review comment:
       I think these removals break SEMVER - we shouldn't change the defaults for the configuration between majors. Let's keep the schedules, but perhaps add a deprecation?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org