You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/24 06:39:00 UTC

[GitHub] [arrow-datafusion] yjshen commented on a diff in pull request #3238: MINOR: Add bounds check to Column physical expression

yjshen commented on code in PR #3238:
URL: https://github.com/apache/arrow-datafusion/pull/3238#discussion_r953404218


##########
datafusion/physical-expr/src/expressions/column.rs:
##########
@@ -74,21 +74,84 @@ impl PhysicalExpr for Column {
 
     /// Get the data type of this expression, given the schema of the input
     fn data_type(&self, input_schema: &Schema) -> Result<DataType> {
+        self.bounds_check(input_schema)?;

Review Comment:
   Can we move the bound check into the constructor?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org