You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Yong Tang <yo...@outlook.com> on 2016/04/25 05:41:33 UTC

Review Request 46617: Update HttpDockerExecutor with v1 API.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46617/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Qian Zhang, and Vinod Kone.


Bugs: MESOS-5227
    https://issues.apache.org/jira/browse/MESOS-5227


Repository: mesos


Description
-------

This patch updatess HttpDockerExecutor with v1 API.

This is the third step to:
MESOS-5227:
Implement HTTP Docker Executor that uses the Executor Library.


Diffs
-----

  src/docker/http_docker_executor.cpp PRE-CREATION 
  src/internal/devolve.hpp 00842bb0de1dd587f2b47c79f17c0e7bd7f51189 
  src/internal/devolve.cpp 4233246c6838f85189f1b4c7e66d2bc0a3bf5408 

Diff: https://reviews.apache.org/r/46617/diff/


Testing
-------

make check (Ubuntu 14.04)


Thanks,

Yong Tang


Re: Review Request 46617: Update HttpDockerExecutor with v1 API.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46617/#review130344
-----------------------------------------------------------



Patch looks great!

Reviews applied: [46615, 46616, 46617]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 25, 2016, 3:41 a.m., Yong Tang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46617/
> -----------------------------------------------------------
> 
> (Updated April 25, 2016, 3:41 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-5227
>     https://issues.apache.org/jira/browse/MESOS-5227
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updatess HttpDockerExecutor with v1 API.
> 
> This is the third step to:
> MESOS-5227:
> Implement HTTP Docker Executor that uses the Executor Library.
> 
> 
> Diffs
> -----
> 
>   src/docker/http_docker_executor.cpp PRE-CREATION 
>   src/internal/devolve.hpp 00842bb0de1dd587f2b47c79f17c0e7bd7f51189 
>   src/internal/devolve.cpp 4233246c6838f85189f1b4c7e66d2bc0a3bf5408 
> 
> Diff: https://reviews.apache.org/r/46617/diff/
> 
> 
> Testing
> -------
> 
> make check (Ubuntu 14.04)
> 
> 
> Thanks,
> 
> Yong Tang
> 
>