You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/16 14:09:57 UTC

[GitHub] [flink] dannycranmer commented on a change in pull request #14407: [FLINK-20630][dynamodb] DynamoDB Streams Consumer fails to consume from Latest

dannycranmer commented on a change in pull request #14407:
URL: https://github.com/apache/flink/pull/14407#discussion_r544327065



##########
File path: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/DynamoDBStreamsDataFetcher.java
##########
@@ -85,30 +101,13 @@ protected boolean shouldAdvanceLastDiscoveredShardId(String shardId, String last
 		return true;
 	}
 
-	/**
-	 * Create a new DynamoDB streams shard consumer.
-	 *
-	 * @param subscribedShardStateIndex the state index of the shard this consumer is subscribed to
-	 * @param handle stream handle
-	 * @param lastSeqNum last sequence number
-	 * @param metricGroup the metric group to report metrics to
-	 * @return
-	 */
 	@Override
-	protected ShardConsumer<T> createShardConsumer(

Review comment:
       This overridden method was identical to the super class, hence deleted




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org