[GitHub] [gobblin] phet commented on a diff in pull request #3707: [GOBBLIN-1846] Validate Multi-active Scheduler with Logs

["phet (via GitHub)" <gi...@apache.org>]

phet commented on code in PR #3707:
URL: https://github.com/apache/gobblin/pull/3707#discussion_r1236004762


##########
gobblin-runtime/src/main/java/org/apache/gobblin/scheduler/JobScheduler.java:
##########
@@ -398,7 +398,8 @@ public void scheduleJob(Properties jobProps, JobListener jobListener, Map<String
       // Schedule the Quartz job with a trigger built from the job configuration
       Trigger trigger = createTriggerForJob(job.getKey(), jobProps);
       this.scheduler.getScheduler().scheduleJob(job, trigger);
-      LOG.info(String.format("Scheduled job %s. Next run: %s.", job.getKey(), trigger.getNextFireTime()));
+      LOG.info("Scheduler trigger validation: [flowName: {} flowGroup: {}] - nextTriggerTime: {} - "
+          + "Job scheduled", job.getKey().getName(), job.getKey().getGroup(), trigger.getNextFireTime());

Review Comment:
   nit: it says "trigger validation", but did it?  seems more like tracing.



##########
gobblin-runtime/src/main/java/org/apache/gobblin/scheduler/JobScheduler.java:
##########
@@ -612,7 +613,10 @@ public void executeImpl(JobExecutionContext context)
       long triggerTimestampMillis = trigger.getPreviousFireTime().getTime();
       jobProps.setProperty(ConfigurationKeys.SCHEDULER_EVENT_TO_TRIGGER_TIMESTAMP_MILLIS_KEY,
           String.valueOf(triggerTimestampMillis));
-
+      LOG.info("Scheduler trigger validation: [flowName: {} flowGroup: {}] - triggerTime: {} nextTriggerTime: {} - "
+              + "Job triggered by scheduler",

Review Comment:
   the other one said "job scheduled" and this one says "job triggered by scheduler".
   
   is this one not also being scheduled?  if it is, suggest:
   "job newly scheduled"
   "job re-scheduled"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org