You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "yaooqinn (via GitHub)" <gi...@apache.org> on 2023/08/24 02:26:49 UTC
[GitHub] [spark] yaooqinn commented on a diff in pull request #42638: [SPARK-44936][CORE] Simplify the log when Spark HybridStore hits the memory limit
yaooqinn commented on code in PR #42638:
URL: https://github.com/apache/spark/pull/42638#discussion_r1303716220
##########
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala:
##########
@@ -1230,6 +1230,10 @@ private[history] class FsHistoryProvider(conf: SparkConf, clock: Clock)
try {
return createHybridStore(dm, appId, attempt, metadata)
} catch {
+ case e: RuntimeException if e.getMessage.contains("Not enough memory to create hybrid") =>
Review Comment:
```suggestion
case e: RuntimeException
if e.getMessage != null && e.getMessage.contains("Not enough memory to create hybrid") =>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org