You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bval.apache.org by "Carlos Vara (JIRA)" <ji...@apache.org> on 2010/04/29 15:38:55 UTC
[jira] Created: (BVAL-30) Groups from the main constraint
annotation must be inherited by the composing annotations
Groups from the main constraint annotation must be inherited by the composing annotations
-----------------------------------------------------------------------------------------
Key: BVAL-30
URL: https://issues.apache.org/jira/browse/BVAL-30
Project: BeanValidation
Issue Type: Bug
Components: jsr303
Affects Versions: 0.1-incubating
Reporter: Carlos Vara
Groups from the main constraint annotation are inherited by the composing annotations, and any groups definition on a composing annotation must be ignored.
Fixed this by giving access to the parent constraint group list in AppendValidationToBuilder, and by ensuring that this list is copied to children AppendValidationToBuilder's when they are created.
I have an easier to understand fix that does a post-processing of the metabean to achieve the same results. I left it commented in case you prefer it.
Added some tests to validate the rule. 3 more TCK test pass.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (BVAL-30) Groups from the main constraint
annotation must be inherited by the composing annotations
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BVAL-30?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Donald Woods resolved BVAL-30.
------------------------------
Fix Version/s: 0.1-incubating
Resolution: Fixed
committed as r939446
> Groups from the main constraint annotation must be inherited by the composing annotations
> -----------------------------------------------------------------------------------------
>
> Key: BVAL-30
> URL: https://issues.apache.org/jira/browse/BVAL-30
> Project: BeanValidation
> Issue Type: Bug
> Components: jsr303
> Affects Versions: 0.1-incubating
> Reporter: Carlos Vara
> Assignee: Donald Woods
> Fix For: 0.1-incubating
>
> Attachments: bval-jsr303.patch, ConstraintCompositionTest.java
>
>
> Groups from the main constraint annotation are inherited by the composing annotations, and any groups definition on a composing annotation must be ignored.
> Fixed this by giving access to the parent constraint group list in AppendValidationToBuilder, and by ensuring that this list is copied to children AppendValidationToBuilder's when they are created.
> I have an easier to understand fix that does a post-processing of the metabean to achieve the same results. I left it commented in case you prefer it.
> Added some tests to validate the rule. 3 more TCK test pass.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (BVAL-30) Groups from the main constraint
annotation must be inherited by the composing annotations
Posted by "Carlos Vara (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BVAL-30?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carlos Vara updated BVAL-30:
----------------------------
Attachment: bval-jsr303.patch
ConstraintCompositionTest.java
Patch and 2 tests.
> Groups from the main constraint annotation must be inherited by the composing annotations
> -----------------------------------------------------------------------------------------
>
> Key: BVAL-30
> URL: https://issues.apache.org/jira/browse/BVAL-30
> Project: BeanValidation
> Issue Type: Bug
> Components: jsr303
> Affects Versions: 0.1-incubating
> Reporter: Carlos Vara
> Attachments: bval-jsr303.patch, ConstraintCompositionTest.java
>
>
> Groups from the main constraint annotation are inherited by the composing annotations, and any groups definition on a composing annotation must be ignored.
> Fixed this by giving access to the parent constraint group list in AppendValidationToBuilder, and by ensuring that this list is copied to children AppendValidationToBuilder's when they are created.
> I have an easier to understand fix that does a post-processing of the metabean to achieve the same results. I left it commented in case you prefer it.
> Added some tests to validate the rule. 3 more TCK test pass.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (BVAL-30) Groups from the main constraint
annotation must be inherited by the composing annotations
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BVAL-30?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Donald Woods reassigned BVAL-30:
--------------------------------
Assignee: Donald Woods
> Groups from the main constraint annotation must be inherited by the composing annotations
> -----------------------------------------------------------------------------------------
>
> Key: BVAL-30
> URL: https://issues.apache.org/jira/browse/BVAL-30
> Project: BeanValidation
> Issue Type: Bug
> Components: jsr303
> Affects Versions: 0.1-incubating
> Reporter: Carlos Vara
> Assignee: Donald Woods
> Attachments: bval-jsr303.patch, ConstraintCompositionTest.java
>
>
> Groups from the main constraint annotation are inherited by the composing annotations, and any groups definition on a composing annotation must be ignored.
> Fixed this by giving access to the parent constraint group list in AppendValidationToBuilder, and by ensuring that this list is copied to children AppendValidationToBuilder's when they are created.
> I have an easier to understand fix that does a post-processing of the metabean to achieve the same results. I left it commented in case you prefer it.
> Added some tests to validate the rule. 3 more TCK test pass.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.