You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by michaelandrepearce <gi...@git.apache.org> on 2018/09/08 00:14:31 UTC
[GitHub] activemq-artemis pull request #2300: ARTEMIS-2081 listConfiguredQueues retur...
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/2300
ARTEMIS-2081 listConfiguredQueues returns only queues created by config
Extend test case to reproduce problem of client created queues being incorrectly removed on simple reload of config.
Add a flag/field to the queues created by configuration/broker.xml so we can correctly filter only queues created/managed by config.
Update listConfiguredQueues to use the new queue flag
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michaelandrepearce/activemq-artemis ARTEMIS-2081
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2300.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2300
----
commit 3d6171c108b3015277e4c81fb9912e88254dd156
Author: Michael André Pearce <mi...@...>
Date: 2018-09-07T23:23:55Z
ARTEMIS-2081 listConfiguredQueues returns only queues created by config
Extend test case to reproduce problem of client created queues being incorrectly removed on simple reload of config.
Add a flag/field to the queues created by configuration/broker.xml so we can correctly filter only queues created/managed by config.
Update listConfiguredQueues to use the new queue flag
----
---
[GitHub] activemq-artemis issue #2300: ARTEMIS-2081 listConfiguredQueues returns only...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2300
Can we talk on IRC on next tuesday? (Planning a day out )
---
[GitHub] activemq-artemis issue #2300: ARTEMIS-2081 listConfiguredQueues returns only...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2300
@michaelandrepearce it's not difficult... probably a 10 min job.. but it's easier for you to do since you know your changes.
I could do it.. but i would probably take longer than you.
---
[GitHub] activemq-artemis issue #2300: ARTEMIS-2081 listConfiguredQueues returns only...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2300
Sure. Will do.
You can also cherry pick -x on the branch.
---
[GitHub] activemq-artemis issue #2300: ARTEMIS-2081 listConfiguredQueues returns only...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2300
Leave it on 2.7 im of the opinion hot fix branch should be only for mission critical fixes.
---
[GitHub] activemq-artemis pull request #2300: ARTEMIS-2081 listConfiguredQueues retur...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2300
---
[GitHub] activemq-artemis issue #2300: ARTEMIS-2081 listConfiguredQueues returns only...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2300
If it comes more important can cherry pick in future
---
[GitHub] activemq-artemis issue #2300: ARTEMIS-2081 listConfiguredQueues returns only...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2300
In that case merge this as is. I was just being paranoid i guess :)
---
[GitHub] activemq-artemis issue #2300: ARTEMIS-2081 listConfiguredQueues returns only...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2300
The more i think about this, i think i should, dont merge it, ill make a new policy so this way it just avoids any risk of someone else may have built on the existing behaviour
---
[GitHub] activemq-artemis issue #2300: ARTEMIS-2081 listConfiguredQueues returns only...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2300
consumers before dispatch.. that's not a feature suitable for 2.6.x.. is it? that means it would be 2.
If you convince everybody that consumersBeforeDispatch is suitable for 2.6.x, then we can go 1, but at this moment I think that's purely a feature and not suitable.
that's why I was a bit afraid of adding stuff into the journals before a final release.
We should probably add 2.6.latest on the compatibility tests before release 2.7.0
---
[GitHub] activemq-artemis issue #2300: ARTEMIS-2081 listConfiguredQueues returns only...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2300
@clebertsuconic i only wander should i create a new delete policy for the new predicate logic, in case someone relies on the existing behaviour (even though not what was planned?)
---
[GitHub] activemq-artemis issue #2300: ARTEMIS-2081 listConfiguredQueues returns only...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2300
@michaelandrepearce I merged it into master.
i was considering it bringing it into 2.6.x, but it's a bit hard... journal encode changes makes it an improvement and would make it 2.7.0... and there was also a few other clashes.
I am not too concerned about the journal binding change.. but if you want it on 2.6.x, can you solve conflicts and send a cherry-pick -x
---
[GitHub] activemq-artemis issue #2300: ARTEMIS-2081 listConfiguredQueues returns only...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2300
So first then ill make a pr to switch that on master and then i can send a cherrypick safely. Ill get this done tomorrow
---
[GitHub] activemq-artemis issue #2300: ARTEMIS-2081 listConfiguredQueues returns only...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2300
I doubt that. We should keep it simple IMO.
---
[GitHub] activemq-artemis issue #2300: ARTEMIS-2081 listConfiguredQueues returns only...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2300
@clebertsuconic there is a small issue cherrypicking this:
1) ill need to cherry pick in the consumers before dispatch change, as thats in 2.7 and these fields are written before the isConfigurationManaged
OR
2) i need to switch round the order the fields are written and read in master quick, else this would cause issue in the persisted queue binding journal.
what would you rather i do?
---
[GitHub] activemq-artemis issue #2300: ARTEMIS-2081 listConfiguredQueues returns only...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2300
@clebertsuconic this is a bug in feature i added a while back, if chance to fit this in 2.6.4 ?
---