[GitHub] cloudstack pull request: Quota master

[bhaisaab <gi...@git.apache.org>]

Github user bhaisaab commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/689#discussion_r38385699
  
    --- Diff: engine/schema/src/com/cloud/usage/dao/UsageDaoImpl.java ---
    @@ -469,4 +478,25 @@ public void removeOldUsageRecords(int days) {
                 txn.close();
             }
         }
    +
    +    @SuppressWarnings("deprecation")
    +    public Pair<List<? extends UsageVO>, Integer> getUsageRecordsPendingQuotaAggregation(final long accountId, final long domainId) {
    +        final short opendb = TransactionLegacy.currentTxn().getDatabaseId();
    +        TransactionLegacy.open(TransactionLegacy.USAGE_DB).close();
    --- End diff --
    
    @jburwell the dao uses connection multiplexing; so if we don't switch back to the previous DB several queries will fail as they will be execute on USAGE_DB instead of CLOUD_DB. This pattern is widely used across the codebase.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---