You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by "xiaoxiang781216 (via GitHub)" <gi...@apache.org> on 2023/01/26 02:43:10 UTC

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8224: sched: Implement tkill/tgkill

xiaoxiang781216 commented on code in PR #8224:
URL: https://github.com/apache/nuttx/pull/8224#discussion_r1087388498


##########
sched/signal/sig_tgkill.c:
##########
@@ -67,14 +65,13 @@
  *
  ****************************************************************************/
 
-int pthread_kill(pthread_t thread, int signo)
+int tgkill(pid_t pid, pid_t tid, int signo)

Review Comment:
   Can not, since pid mean the main task pid, not the calling thread tid if it isn't -1.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org