You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "wForget (via GitHub)" <gi...@apache.org> on 2023/11/06 09:35:12 UTC
[PR] Provide TPCDSRunQueryContext to conveniently run tpcds queries [kyuubi]
wForget opened a new pull request, #5635:
URL: https://github.com/apache/kyuubi/pull/5635
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
Provide `TPCDSRunQueryContext` to conveniently run tpcds queries.
+ `runAllQueries()`: run all queries
+ `runQuery(query: String)`/`runQueries(queries: String*)`: run the specified query or queries
With the kyuubi scala execution mode, we can conveniently run tpcds queries:
```
set kyuubi.operation.language=scala;
import org.apache.kyuubi.spark.connector.tpcds.TPCDSRunQueryContext;
val queryContext = TPCDSRunQueryContext("tpcds.tiny");
val result = queryContext.runAllQueries();
// queryContext.runQueries("q1", "q2", "q3", "q4").show();
result.show(200);
```
### _How was this patch tested?_
- [X] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [X] Add screenshots for manual tests if appropriate
- [X] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request
### _Was this patch authored or co-authored using generative AI tooling?_
<!--
If a generative AI tooling has been used in the process of authoring this patch, please include
phrase 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5635] Provide TPCDSRunQueryContext to conveniently run tpcds queries [kyuubi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5635:
URL: https://github.com/apache/kyuubi/pull/5635#issuecomment-1803075464
## [Codecov](https://app.codecov.io/gh/apache/kyuubi/pull/5635?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#5635](https://app.codecov.io/gh/apache/kyuubi/pull/5635?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (feeaaf4) into [master](https://app.codecov.io/gh/apache/kyuubi/commit/f23b6de6b3751fc2592eb834107b7381cf7ce130?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f23b6de) will **increase** coverage by `0.17%`.
> Report is 14 commits behind head on master.
> The diff coverage is `91.02%`.
> :exclamation: Current head feeaaf4 differs from pull request most recent head 7e37ea1. Consider uploading reports for the commit 7e37ea1 to get more accurate results
```diff
@@ Coverage Diff @@
## master #5635 +/- ##
============================================
+ Coverage 61.36% 61.54% +0.17%
Complexity 23 23
============================================
Files 603 604 +1
Lines 35635 35791 +156
Branches 4874 4878 +4
============================================
+ Hits 21867 22026 +159
+ Misses 11387 11377 -10
- Partials 2381 2388 +7
```
| [Files](https://app.codecov.io/gh/apache/kyuubi/pull/5635?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/spark/connector/tpcds/TPCDSRunQueryContext.scala](https://app.codecov.io/gh/apache/kyuubi/pull/5635?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXh0ZW5zaW9ucy9zcGFyay9reXV1Ymktc3BhcmstY29ubmVjdG9yLXRwY2RzL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NwYXJrL2Nvbm5lY3Rvci90cGNkcy9UUENEU1J1blF1ZXJ5Q29udGV4dC5zY2FsYQ==) | `91.02% <91.02%> (ø)` | |
... and [17 files with indirect coverage changes](https://app.codecov.io/gh/apache/kyuubi/pull/5635/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in [Chrome](https://chrome.google.com/webstore/detail/codecov/gedikamndpbemklijjkncpnolildpbgo) or [Firefox](https://addons.mozilla.org/en-US/firefox/addon/codecov/) today!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5635] Provide TPCDSRunQueryContext/TPCDSGenerateContext to conveniently run tpcds queries and generate tpcds tables [kyuubi]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #5635: [KYUUBI #5635] Provide TPCDSRunQueryContext/TPCDSGenerateContext to conveniently run tpcds queries and generate tpcds tables
URL: https://github.com/apache/kyuubi/pull/5635
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5635] Provide TPCDSRunQueryContext/TPCDSGenerateContext to conveniently run tpcds queries and generate tpcds tables [kyuubi]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5635:
URL: https://github.com/apache/kyuubi/pull/5635#issuecomment-1962164684
Thanks for the PR! This PR is being closed due to inactivity. This isn't a judgement on the merit of the PR in any way. If this is still an issue with the latest version of Kyuubi, please reopen it and ask a committer to remove the Stale tag!
Thank you for using Kyuubi!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5635] Provide TPCDSRunQueryContext/TPCDSGenerateContext to conveniently run tpcds queries and generate tpcds tables [kyuubi]
Posted by "wForget (via GitHub)" <gi...@apache.org>.
wForget commented on PR #5635:
URL: https://github.com/apache/kyuubi/pull/5635#issuecomment-1811877142
@pan3793 @ulysses-you Could you please take a look? I am not sure if this is a universal way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org