You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2013/08/25 20:58:41 UTC

[Bug 55164] [PATCH] Support for adding slide notes

https://issues.apache.org/bugzilla/show_bug.cgi?id=55164

--- Comment #3 from Jan Tošovský <ja...@gmail.com> ---
Created attachment 30761
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=30761&action=edit
Enhanced patch

This patch can add new slide notes into a new presentation as well as into the
existing one. This functionality is covered by three basic tests.

Problem in Office 2010 was caused by a lower tolerance when reusing the theme.
Notes Master has to be linked to the different theme than the slides (but the
theme itself can be the same, just with a different name).

So for the Notes Master, if not already specified, the theme of the first slide
is reused (cloned). I don't know if my method is the best. There were no
answers:
http://osdir.com/ml/dev-poi.apache.org/2013-08/msg00154.html

There are also issues in validation tool. They are caused by invalid 'Notes
Slide' relations in presentation.xml.rels. They are created automatically.
Maybe a new option for such cases will be needed. Discussed here:
http://osdir.com/ml/dev-poi.apache.org/2013-08/msg00155.html

In two places I work with the index of targetURis (e.g. 2 in /theme2.xml path).
For this purpose I created a new helper method in POIXMLRelation class:
public Integer getFileNameIndex(POIXMLDocumentPart part)

Most of comments above is still valid.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org