You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2024/04/03 09:49:00 UTC
[jira] [Commented] (MRESOLVER-518) Improvements for version selector
[ https://issues.apache.org/jira/browse/MRESOLVER-518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833473#comment-17833473 ]
ASF GitHub Bot commented on MRESOLVER-518:
------------------------------------------
gnodet commented on code in PR #450:
URL: https://github.com/apache/maven-resolver/pull/450#discussion_r1549377629
##########
maven-resolver-api/src/main/java/org/eclipse/aether/collection/UnsolvableVersionConflictException.java:
##########
@@ -42,9 +42,25 @@ public class UnsolvableVersionConflictException extends RepositoryException {
* Creates a new exception with the specified paths to conflicting nodes in the dependency graph.
*
* @param paths The paths to the dependency nodes that participate in the version conflict, may be {@code null}.
+ * @deprecated Use {@link #UnsolvableVersionConflictException(String, Collection)} instead.
Review Comment:
I don't see the point of deprecating this constructor, since it forces the addition of a `null` parameter and lead the user to a change which is useless, given the message has a default value.
> Improvements for version selector
> ---------------------------------
>
> Key: MRESOLVER-518
> URL: https://issues.apache.org/jira/browse/MRESOLVER-518
> Project: Maven Resolver
> Issue Type: New Feature
> Components: Resolver
> Reporter: Tamas Cservenak
> Assignee: Tamas Cservenak
> Priority: Major
> Fix For: 2.0.0, 2.0.0-alpha-11
>
>
> Currently Resolver "silently" resolves conflict based on "nearest" strategy, without any assumption about selected version (simply the fact it is "nearer to root" makes it win).
> Extend this logic by ability to fail collection in case of version conflict, version divergence and "version incompatibility" for start. As it may come handy, and user may want to fix the build differently than Maven would.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)