You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/11/13 20:07:28 UTC

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590:
URL: https://github.com/apache/kafka/pull/9590#discussion_r523195958



##########
File path: core/src/main/scala/kafka/log/LogCleaner.scala
##########
@@ -538,6 +539,14 @@ private[log] class Cleaner(val id: Int,
     for (group <- groupedSegments)
       cleanSegments(log, group, offsetMap, deleteHorizonMs, stats, transactionMetadata)
 
+    if (baseOffset == log.logStartOffset) {

Review comment:
       Good catch. The if statement is left from an earlier implementation. I believe cleanable.log will always be the entire log and always have baseOffset be log.logStartOffset.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org