You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Pyasma (via GitHub)" <gi...@apache.org> on 2025/12/30 11:11:27 UTC

[PR] Pyasma/add proper dependencies for sqlalchemy/edge3 [airflow]

Pyasma opened a new pull request, #59932:
URL: https://github.com/apache/airflow/pull/59932

   <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
   
      http://www.apache.org/licenses/LICENSE-2.0
   
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
   Issue no: #59901
   
   I added try except block on sqlalchemy import 
   
   added optional dependency in pyproject.toml
   
   prek checks passed
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   
   
   <!-- Please keep an empty line above the dashes. -->
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Pyasma/add proper dependencies for sqlalchemy/edge3 [airflow]

Posted by "Pyasma (via GitHub)" <gi...@apache.org>.
Pyasma commented on PR #59932:
URL: https://github.com/apache/airflow/pull/59932#issuecomment-3699088061

   @jscheffl Thanks for the Review I see it's not an optional choice for Edge and must 
   
   should i close this PR and mention in the open issue that edge should be excluded from it 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Pyasma/add proper dependencies for sqlalchemy/edge3 [airflow]

Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #59932:
URL: https://github.com/apache/airflow/pull/59932#issuecomment-3700654522

   Sorry came a bit late ... yes closing for now I assume is the best option.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Pyasma/add proper dependencies for sqlalchemy/edge3 [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed pull request #59932: Pyasma/add proper dependencies for sqlalchemy/edge3
URL: https://github.com/apache/airflow/pull/59932


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Pyasma/add proper dependencies for sqlalchemy/edge3 [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #59932:
URL: https://github.com/apache/airflow/pull/59932#issuecomment-3700651584

   > I assume Edge must be actually excluded from the attempt to define sqlalchemy explicitly, it needs a strong dependency to core until we maybe have changed the packaging of executors in another way.
   
   > should i close this PR and mention in the open issue that edge should be excluded from it ?
   
   Yeah. I think we should close it, but it's also as Jens wrote a sign that we need to extract the "worker" part to separte distributon. Currently, when you install edge3 provider - you will also need to install "apache-airflow" - which is only needed for executor part. But for now - I coinsider edge3 provider as "done" in context of that task.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Pyasma/add proper dependencies for sqlalchemy/edge3 [airflow]

Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #59932:
URL: https://github.com/apache/airflow/pull/59932#issuecomment-3699075483

   I assume Edge must be actually excluded from the attempt to define sqlalchemy explicitly, it needs a strong dependency to core until we maybe have changed the packaging of executors in another way.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Pyasma/add proper dependencies for sqlalchemy/edge3 [airflow]

Posted by "Pyasma (via GitHub)" <gi...@apache.org>.
Pyasma commented on PR #59932:
URL: https://github.com/apache/airflow/pull/59932#issuecomment-3699049280

   ignore this push there was some error from my side


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Pyasma/add proper dependencies for sqlalchemy/edge3 [airflow]

Posted by "Pyasma (via GitHub)" <gi...@apache.org>.
Pyasma closed pull request #59932: Pyasma/add proper dependencies for sqlalchemy/edge3
URL: https://github.com/apache/airflow/pull/59932


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org