You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2022/08/02 18:20:32 UTC
[native-toolchain-CR] IMPALA-9999: Build the toolchain with GCC 10
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18806
Change subject: IMPALA-9999: Build the toolchain with GCC 10
......................................................................
IMPALA-9999: Build the toolchain with GCC 10
This switches the toolchain to build with GCC 10.
This required several version changes and patches
due to new warnings or changes in default settings:
1. LLVM is patched to fix compilation in lli
(type mismatch on char)
2. crcutil is upgraded to the latest to handle the
two digit GCC version. The new version incorporates
the two patches previously used.
3. libunwind is upgraded to 1.5.1 due to GCC 10
switch to -fno-common by default. The new
version incorporates a couple of the previous
patches.
4. Breakpad is upgraded to a recent commit (from late
March 2022), which uses a newer version of lss
that can compile with GCC 10.
5. Flatbuffers is upgraded to 1.12.0, which fixes
a constness casting issue
6. The TPC-DS library is patched to use -fcommon,
as GCC 10 switched to -fno-common by default.
This upgrade GCC to 10.4 and binutils to 2.35.1.
This changes GCC's build command to build GCC using
link time optimization. This should speed up GCC's
execution, but it has no other impact. Building GCC
with LTO requires GCC compilation to use an updated
binutils, so this modifies the build script to build
binutils first and use that for GCC.
GCC 10.4 requires a patch to libstdc++ to fix missing
noexcepts, otherwise Clang compilation of Impala fails.
Testing:
- This has built on all supported platforms, and
Impala can build and operate with this toolchain.
Change-Id: I2fbfcdcb497ad60772bf0a7837e4043ae75bcfaa
---
M buildall.sh
M functions.sh
M init-compiler.sh
M init.sh
A source/breakpad/breakpad-e09741c609dcd5f5274d40182c5e2cc9a002d5ba-patches/0001-Add-basic-support-for-dwz-dwarf-extension.patch
A source/breakpad/breakpad-e09741c609dcd5f5274d40182c5e2cc9a002d5ba-patches/0002-Build-breakpad-e09741c6-on-ppc64le.patch
M source/gcc/build.sh
A source/gcc/gcc-10.4.0-patches/0001-libstdc-Fix-inconsistent-noexcept-specific-for-valar.patch
A source/libunwind/libunwind-1.5.0-patches/0001-libunwind-trace-cache-destructor.patch
A source/llvm/llvm-5.0.1-patches/0005-PATCH-Fix-lli-compilation-on-gcc8.patch
A source/tpc-ds/tpc-ds-2.1.0-patches/0001-PATCH-Fix-compilation-on-gcc10-fcommon.patch
11 files changed, 687 insertions(+), 28 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/06/18806/1
--
To view, visit http://gerrit.cloudera.org:8080/18806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2fbfcdcb497ad60772bf0a7837e4043ae75bcfaa
Gerrit-Change-Number: 18806
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[native-toolchain-CR] IMPALA-9999: Build the toolchain with GCC 10
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Michael Smith,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18806
to look at the new patch set (#3).
Change subject: IMPALA-9999: Build the toolchain with GCC 10
......................................................................
IMPALA-9999: Build the toolchain with GCC 10
This switches the toolchain to build with GCC 10.
This required several version changes and patches
due to new warnings or changes in default settings:
1. LLVM is patched to fix compilation in lli
(type mismatch on char)
2. crcutil is upgraded to the latest to handle the
two digit GCC version. The new version incorporates
the two patches previously used.
3. libunwind is upgraded to 1.5.1 due to GCC 10
switch to -fno-common by default. The new
version incorporates a couple of the previous
patches.
4. Breakpad is upgraded to a recent commit (from late
March 2022), which uses a newer version of lss
that can compile with GCC 10.
5. Flatbuffers is upgraded to 1.12.0, which fixes
a constness casting issue
6. The TPC-DS library is patched to use -fcommon,
as GCC 10 switched to -fno-common by default.
This upgrade GCC to 10.4 and binutils to 2.35.1.
This changes GCC's build command to build GCC using
link time optimization. This should speed up GCC's
execution, but it has no other impact. Building GCC
with LTO requires GCC compilation to use an updated
binutils, so this modifies the build script to build
binutils first and use that for GCC.
GCC 10.4 requires a patch to libstdc++ to fix missing
noexcepts, otherwise Clang compilation of Impala fails.
Testing:
- This has built on all supported platforms, and
Impala can build and operate with this toolchain.
Change-Id: I2fbfcdcb497ad60772bf0a7837e4043ae75bcfaa
---
M buildall.sh
M functions.sh
M init-compiler.sh
M init.sh
A source/breakpad/breakpad-e09741c609dcd5f5274d40182c5e2cc9a002d5ba-patches/0001-Add-basic-support-for-dwz-dwarf-extension.patch
A source/breakpad/breakpad-e09741c609dcd5f5274d40182c5e2cc9a002d5ba-patches/0002-Build-breakpad-e09741c6-on-ppc64le.patch
M source/gcc/build.sh
A source/gcc/gcc-10.4.0-patches/0001-libstdc-Fix-inconsistent-noexcept-specific-for-valar.patch
A source/libunwind/libunwind-1.5.0-patches/0001-libunwind-trace-cache-destructor.patch
A source/llvm/llvm-5.0.1-patches/0005-PATCH-Fix-lli-compilation-on-gcc8.patch
A source/tpc-ds/tpc-ds-2.1.0-patches/0001-PATCH-Fix-compilation-on-gcc10-fcommon.patch
11 files changed, 692 insertions(+), 27 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/06/18806/3
--
To view, visit http://gerrit.cloudera.org:8080/18806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2fbfcdcb497ad60772bf0a7837e4043ae75bcfaa
Gerrit-Change-Number: 18806
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[native-toolchain-CR] IMPALA-9999: Build the toolchain with GCC 10
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18806 )
Change subject: IMPALA-9999: Build the toolchain with GCC 10
......................................................................
IMPALA-9999: Build the toolchain with GCC 10
This switches the toolchain to build with GCC 10.
This required several version changes and patches
due to new warnings or changes in default settings:
1. LLVM is patched to fix compilation in lli
(type mismatch on char)
2. crcutil is upgraded to the latest to handle the
two digit GCC version. The new version incorporates
the two patches previously used.
3. libunwind is upgraded to 1.5.1 due to GCC 10
switch to -fno-common by default. The new
version incorporates a couple of the previous
patches.
4. Breakpad is upgraded to a recent commit (from late
March 2022), which uses a newer version of lss
that can compile with GCC 10.
5. Flatbuffers is upgraded to 1.12.0, which fixes
a constness casting issue
6. The TPC-DS library is patched to use -fcommon,
as GCC 10 switched to -fno-common by default.
7. GDB fails to compile on ARM due to the switch
to -fno-common, so this adds newer GDB versions
without that issue.
This upgrade GCC to 10.4 and binutils to 2.35.1.
This changes GCC's build command to build GCC using
link time optimization. This should speed up GCC's
execution, but it has no other impact. Building GCC
with LTO requires GCC compilation to use an updated
binutils, so this modifies the build script to build
binutils first and use that for GCC.
GCC 10.4 requires a patch to libstdc++ to fix missing
noexcepts, otherwise Clang compilation of Impala fails.
Testing:
- This has built on all supported platforms, and
Impala can build and operate with this toolchain.
Change-Id: I2fbfcdcb497ad60772bf0a7837e4043ae75bcfaa
Reviewed-on: http://gerrit.cloudera.org:8080/18806
Reviewed-by: Michael Smith <mi...@cloudera.com>
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Tested-by: Joe McDonnell <jo...@cloudera.com>
---
M buildall.sh
M functions.sh
M init-compiler.sh
M init.sh
A source/breakpad/breakpad-e09741c609dcd5f5274d40182c5e2cc9a002d5ba-patches/0001-Add-basic-support-for-dwz-dwarf-extension.patch
A source/breakpad/breakpad-e09741c609dcd5f5274d40182c5e2cc9a002d5ba-patches/0002-Build-breakpad-e09741c6-on-ppc64le.patch
M source/gcc/build.sh
A source/gcc/gcc-10.4.0-patches/0001-libstdc-Fix-inconsistent-noexcept-specific-for-valar.patch
M source/gdb/build.sh
A source/libunwind/libunwind-1.5.0-patches/0001-libunwind-trace-cache-destructor.patch
A source/llvm/llvm-5.0.1-patches/0005-PATCH-Fix-lli-compilation-on-gcc8.patch
A source/tpc-ds/tpc-ds-2.1.0-patches/0001-PATCH-Fix-compilation-on-gcc10-fcommon.patch
12 files changed, 710 insertions(+), 31 deletions(-)
Approvals:
Michael Smith: Looks good to me, but someone else must approve
Wenzhe Zhou: Looks good to me, approved
Joe McDonnell: Verified
--
To view, visit http://gerrit.cloudera.org:8080/18806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2fbfcdcb497ad60772bf0a7837e4043ae75bcfaa
Gerrit-Change-Number: 18806
Gerrit-PatchSet: 6
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[native-toolchain-CR] IMPALA-9999: Build the toolchain with GCC 10
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/18806 )
Change subject: IMPALA-9999: Build the toolchain with GCC 10
......................................................................
IMPALA-9999: Build the toolchain with GCC 10
This switches the toolchain to build with GCC 10.
This required several version changes and patches
due to new warnings or changes in default settings:
1. LLVM is patched to fix compilation in lli
(type mismatch on char)
2. crcutil is upgraded to the latest to handle the
two digit GCC version. The new version incorporates
the two patches previously used.
3. libunwind is upgraded to 1.5.1 due to GCC 10
switch to -fno-common by default. The new
version incorporates a couple of the previous
patches.
4. Breakpad is upgraded to a recent commit (from late
March 2022), which uses a newer version of lss
that can compile with GCC 10.
5. Flatbuffers is upgraded to 1.12.0, which fixes
a constness casting issue
6. The TPC-DS library is patched to use -fcommon,
as GCC 10 switched to -fno-common by default.
7. GDB fails to compile on ARM due to the switch
to -fno-common, so this adds newer GDB versions
without that issue.
This upgrade GCC to 10.4 and binutils to 2.35.1.
This changes GCC's build command to build GCC using
link time optimization. This should speed up GCC's
execution, but it has no other impact. Building GCC
with LTO requires GCC compilation to use an updated
binutils, so this modifies the build script to build
binutils first and use that for GCC.
GCC 10.4 requires a patch to libstdc++ to fix missing
noexcepts, otherwise Clang compilation of Impala fails.
Testing:
- This has built on all supported platforms, and
Impala can build and operate with this toolchain.
Change-Id: I2fbfcdcb497ad60772bf0a7837e4043ae75bcfaa
---
M buildall.sh
M functions.sh
M init-compiler.sh
M init.sh
A source/breakpad/breakpad-e09741c609dcd5f5274d40182c5e2cc9a002d5ba-patches/0001-Add-basic-support-for-dwz-dwarf-extension.patch
A source/breakpad/breakpad-e09741c609dcd5f5274d40182c5e2cc9a002d5ba-patches/0002-Build-breakpad-e09741c6-on-ppc64le.patch
M source/gcc/build.sh
A source/gcc/gcc-10.4.0-patches/0001-libstdc-Fix-inconsistent-noexcept-specific-for-valar.patch
M source/gdb/build.sh
A source/libunwind/libunwind-1.5.0-patches/0001-libunwind-trace-cache-destructor.patch
A source/llvm/llvm-5.0.1-patches/0005-PATCH-Fix-lli-compilation-on-gcc8.patch
A source/tpc-ds/tpc-ds-2.1.0-patches/0001-PATCH-Fix-compilation-on-gcc10-fcommon.patch
12 files changed, 710 insertions(+), 31 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/06/18806/5
--
To view, visit http://gerrit.cloudera.org:8080/18806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2fbfcdcb497ad60772bf0a7837e4043ae75bcfaa
Gerrit-Change-Number: 18806
Gerrit-PatchSet: 5
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[native-toolchain-CR] IMPALA-9999: Build the toolchain with GCC 10
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18806 )
Change subject: IMPALA-9999: Build the toolchain with GCC 10
......................................................................
Patch Set 5: Verified+1
Build passes and Impala is able to build/run with the resulting toolchain.
Impala change here: https://gerrit.cloudera.org/#/c/18134/
--
To view, visit http://gerrit.cloudera.org:8080/18806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbfcdcb497ad60772bf0a7837e4043ae75bcfaa
Gerrit-Change-Number: 18806
Gerrit-PatchSet: 5
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Sep 2022 15:49:45 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-9999: Build the toolchain with GCC 10
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Michael Smith,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18806
to look at the new patch set (#2).
Change subject: IMPALA-9999: Build the toolchain with GCC 10
......................................................................
IMPALA-9999: Build the toolchain with GCC 10
This switches the toolchain to build with GCC 10.
This required several version changes and patches
due to new warnings or changes in default settings:
1. LLVM is patched to fix compilation in lli
(type mismatch on char)
2. crcutil is upgraded to the latest to handle the
two digit GCC version. The new version incorporates
the two patches previously used.
3. libunwind is upgraded to 1.5.1 due to GCC 10
switch to -fno-common by default. The new
version incorporates a couple of the previous
patches.
4. Breakpad is upgraded to a recent commit (from late
March 2022), which uses a newer version of lss
that can compile with GCC 10.
5. Flatbuffers is upgraded to 1.12.0, which fixes
a constness casting issue
6. The TPC-DS library is patched to use -fcommon,
as GCC 10 switched to -fno-common by default.
This upgrade GCC to 10.4 and binutils to 2.35.1.
This changes GCC's build command to build GCC using
link time optimization. This should speed up GCC's
execution, but it has no other impact. Building GCC
with LTO requires GCC compilation to use an updated
binutils, so this modifies the build script to build
binutils first and use that for GCC.
GCC 10.4 requires a patch to libstdc++ to fix missing
noexcepts, otherwise Clang compilation of Impala fails.
Testing:
- This has built on all supported platforms, and
Impala can build and operate with this toolchain.
Change-Id: I2fbfcdcb497ad60772bf0a7837e4043ae75bcfaa
---
M buildall.sh
M functions.sh
M init-compiler.sh
M init.sh
A source/breakpad/breakpad-e09741c609dcd5f5274d40182c5e2cc9a002d5ba-patches/0001-Add-basic-support-for-dwz-dwarf-extension.patch
A source/breakpad/breakpad-e09741c609dcd5f5274d40182c5e2cc9a002d5ba-patches/0002-Build-breakpad-e09741c6-on-ppc64le.patch
M source/gcc/build.sh
A source/gcc/gcc-10.4.0-patches/0001-libstdc-Fix-inconsistent-noexcept-specific-for-valar.patch
A source/libunwind/libunwind-1.5.0-patches/0001-libunwind-trace-cache-destructor.patch
A source/llvm/llvm-5.0.1-patches/0005-PATCH-Fix-lli-compilation-on-gcc8.patch
A source/tpc-ds/tpc-ds-2.1.0-patches/0001-PATCH-Fix-compilation-on-gcc10-fcommon.patch
11 files changed, 692 insertions(+), 27 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/06/18806/2
--
To view, visit http://gerrit.cloudera.org:8080/18806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2fbfcdcb497ad60772bf0a7837e4043ae75bcfaa
Gerrit-Change-Number: 18806
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[native-toolchain-CR] IMPALA-9999: Build the toolchain with GCC 10
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18806 )
Change subject: IMPALA-9999: Build the toolchain with GCC 10
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18806/1/buildall.sh
File buildall.sh:
http://gerrit.cloudera.org:8080/#/c/18806/1/buildall.sh@313
PS1, Line 313: LIBUNWIND_VERSION=1.5.0-p1 $SOURCE_DIR/source/libunwind/build.sh
> Why did you skip adding BUILD_HISTORICAL here and for flatbuffers?
Didn't mean to skip doing that, fixed.
http://gerrit.cloudera.org:8080/#/c/18806/1/buildall.sh@319
PS1, Line 319: BREAKPAD_VERSION=20150612-p1 $SOURCE_DIR/source/breakpad/build.sh
> nit: inconsistent indentation
Done
--
To view, visit http://gerrit.cloudera.org:8080/18806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbfcdcb497ad60772bf0a7837e4043ae75bcfaa
Gerrit-Change-Number: 18806
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Aug 2022 00:53:11 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-9999: Build the toolchain with GCC 10
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18806 )
Change subject: IMPALA-9999: Build the toolchain with GCC 10
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18806/5/source/gcc/build.sh
File source/gcc/build.sh:
http://gerrit.cloudera.org:8080/#/c/18806/5/source/gcc/build.sh@32
PS5, Line 32: $GCC_MAJOR_VERSION == '7'
Why drop GCC_VERSION 6.3.0?
--
To view, visit http://gerrit.cloudera.org:8080/18806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbfcdcb497ad60772bf0a7837e4043ae75bcfaa
Gerrit-Change-Number: 18806
Gerrit-PatchSet: 5
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 Sep 2022 12:26:37 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-9999: Build the toolchain with GCC 10
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18806 )
Change subject: IMPALA-9999: Build the toolchain with GCC 10
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18806/1/buildall.sh
File buildall.sh:
http://gerrit.cloudera.org:8080/#/c/18806/1/buildall.sh@313
PS1, Line 313: LIBUNWIND_VERSION=1.5.0-p1 $SOURCE_DIR/source/libunwind/build.sh
Why did you skip adding BUILD_HISTORICAL here and for flatbuffers?
http://gerrit.cloudera.org:8080/#/c/18806/1/buildall.sh@319
PS1, Line 319: BREAKPAD_VERSION=20150612-p1 $SOURCE_DIR/source/breakpad/build.sh
nit: inconsistent indentation
--
To view, visit http://gerrit.cloudera.org:8080/18806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbfcdcb497ad60772bf0a7837e4043ae75bcfaa
Gerrit-Change-Number: 18806
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Aug 2022 16:39:08 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-9999: Build the toolchain with GCC 10
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18806 )
Change subject: IMPALA-9999: Build the toolchain with GCC 10
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbfcdcb497ad60772bf0a7837e4043ae75bcfaa
Gerrit-Change-Number: 18806
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Aug 2022 15:45:30 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-9999: Build the toolchain with GCC 10
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18806 )
Change subject: IMPALA-9999: Build the toolchain with GCC 10
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18806/5/source/gcc/build.sh
File source/gcc/build.sh:
http://gerrit.cloudera.org:8080/#/c/18806/5/source/gcc/build.sh@32
PS5, Line 32: $GCC_MAJOR_VERSION == '7'
> Impala has never used a toolchain built with GCC 6. We went straight from 4
Thanks for clarification
--
To view, visit http://gerrit.cloudera.org:8080/18806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbfcdcb497ad60772bf0a7837e4043ae75bcfaa
Gerrit-Change-Number: 18806
Gerrit-PatchSet: 5
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Sep 2022 00:52:28 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-9999: Build the toolchain with GCC 10
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18806 )
Change subject: IMPALA-9999: Build the toolchain with GCC 10
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18806/5/source/gcc/build.sh
File source/gcc/build.sh:
http://gerrit.cloudera.org:8080/#/c/18806/5/source/gcc/build.sh@32
PS5, Line 32: $GCC_MAJOR_VERSION == '7'
> Why drop GCC_VERSION 6.3.0?
Impala has never used a toolchain built with GCC 6. We went straight from 4.9.2 to 7.5.
--
To view, visit http://gerrit.cloudera.org:8080/18806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbfcdcb497ad60772bf0a7837e4043ae75bcfaa
Gerrit-Change-Number: 18806
Gerrit-PatchSet: 5
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 19 Sep 2022 22:37:15 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-9999: Build the toolchain with GCC 10
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18806 )
Change subject: IMPALA-9999: Build the toolchain with GCC 10
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbfcdcb497ad60772bf0a7837e4043ae75bcfaa
Gerrit-Change-Number: 18806
Gerrit-PatchSet: 5
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 14 Sep 2022 23:40:59 +0000
Gerrit-HasComments: No