Re: [PR] [HUDI-7772] HoodieTimelineArchiver##getCommitInstantsToArchive need skip limiting archiving of instants [hudi]

["danny0405 (via GitHub)" <gi...@apache.org>]

danny0405 commented on code in PR #11245:
URL: https://github.com/apache/hudi/pull/11245#discussion_r1602802363


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/timeline/HoodieTimelineArchiver.java:
##########
@@ -217,6 +217,10 @@ private List<HoodieInstant> getCommitInstantsToArchive() throws IOException {
           earliestInstantToRetainCandidates.add(
               completedCommitsTimeline.findInstantsModifiedAfterByCompletionTime(latestCompactionTime.get()).firstInstant());
         }
+      } catch (UnsupportedOperationException unsupportedOperationException) {
+        // If tableMetadata is FileSystemBackedTableMetadata would throw UnsupportedOperationException, should skip it to
+        // confirm next operation success
+        LOG.warn("tableMetadata is FileSystemBackedTableMetadata and skip limiting archiving of instants.");

Review Comment:
   Why the metadata backend is fs based if metadata is available?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org