You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2013/10/15 09:51:59 UTC
Review Request 14646: CLOUDSTACK-4780:
Fixed-BVT-test-case-TestSnapshotRootDisk.test_01_snapshot_root_disk
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14646/
-----------------------------------------------------------
Review request for cloudstack and SrikanteswaraRao Talluri.
Repository: cloudstack-git
Description
-------
Fixed-BVT-test-case-TestSnapshotRootDisk.test_01_snapshot_root_disk
Used a utility function to check whether the snapshot exists in the secondary storage.
This patch should be applied on top of https://reviews.apache.org/r/14346/ which contains the fix for the utility function used here.
Diffs
-----
test/integration/smoke/test_snapshots.py 06777e4
Diff: https://reviews.apache.org/r/14646/diff/
Testing
-------
Tested locally on KVM Advanced setup:
==> client.log <==
2013-10-14 20:50:32,626 - DEBUG - test_01_snapshot_root_disk (test_snapshots_fixed.TestSnapshotRootDisk) - Snapshot created: ID - b3161412-1cd3-4387-8bfb-aaa2ca
545eeb
2013-10-14 20:50:32,641 - DEBUG - test_01_snapshot_root_disk (test_snapshots_fixed.TestSnapshotRootDisk) - select backup_snap_id, account_id, volume_id from sna
pshots where uuid = 'b3161412-1cd3-4387-8bfb-aaa2ca545eeb';
==> result.log <==
test_01_snapshot_root_disk (test_snapshots_fixed.TestSnapshotRootDisk)
Test Snapshot Root Disk ... ok
----------------------------------------------------------------------
Ran 1 test in 259.875s
OK
Thanks,
Gaurav Aradhye
Re: Review Request 14646: CLOUDSTACK-4780:
Fixed-BVT-test-case-TestSnapshotRootDisk.test_01_snapshot_root_disk
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14646/#review27011
-----------------------------------------------------------
Commit 79d702cf975a482de2235741076348386ca072dd in branch refs/heads/4.2 from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=79d702c ]
CLOUDSTACK-4780: Fixed BVT test case TestSnapshotRootDisk.test_01_snapshot_root_disk
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
(cherry picked from commit b12ff1d6ce964e30d0b919c29ab92af450e4dcf9)
- ASF Subversion and Git Services
On Oct. 15, 2013, 7:51 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14646/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2013, 7:51 a.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fixed-BVT-test-case-TestSnapshotRootDisk.test_01_snapshot_root_disk
> Used a utility function to check whether the snapshot exists in the secondary storage.
>
> This patch should be applied on top of https://reviews.apache.org/r/14346/ which contains the fix for the utility function used here.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_snapshots.py 06777e4
>
> Diff: https://reviews.apache.org/r/14646/diff/
>
>
> Testing
> -------
>
> Tested locally on KVM Advanced setup:
>
> ==> client.log <==
> 2013-10-14 20:50:32,626 - DEBUG - test_01_snapshot_root_disk (test_snapshots_fixed.TestSnapshotRootDisk) - Snapshot created: ID - b3161412-1cd3-4387-8bfb-aaa2ca
> 545eeb
> 2013-10-14 20:50:32,641 - DEBUG - test_01_snapshot_root_disk (test_snapshots_fixed.TestSnapshotRootDisk) - select backup_snap_id, account_id, volume_id from sna
> pshots where uuid = 'b3161412-1cd3-4387-8bfb-aaa2ca545eeb';
>
> ==> result.log <==
> test_01_snapshot_root_disk (test_snapshots_fixed.TestSnapshotRootDisk)
> Test Snapshot Root Disk ... ok
>
> ----------------------------------------------------------------------
> Ran 1 test in 259.875s
>
> OK
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 14646: CLOUDSTACK-4780:
Fixed-BVT-test-case-TestSnapshotRootDisk.test_01_snapshot_root_disk
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14646/#review27041
-----------------------------------------------------------
Commit 986ac0f124ab2960e13455736dfd467350e7f9e1 in branch refs/heads/ui-restyle from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=986ac0f ]
CLOUDSTACK-4780: Fixed BVT test case TestSnapshotRootDisk.test_01_snapshot_root_disk
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
- ASF Subversion and Git Services
On Oct. 15, 2013, 7:51 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14646/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2013, 7:51 a.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fixed-BVT-test-case-TestSnapshotRootDisk.test_01_snapshot_root_disk
> Used a utility function to check whether the snapshot exists in the secondary storage.
>
> This patch should be applied on top of https://reviews.apache.org/r/14346/ which contains the fix for the utility function used here.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_snapshots.py 06777e4
>
> Diff: https://reviews.apache.org/r/14646/diff/
>
>
> Testing
> -------
>
> Tested locally on KVM Advanced setup:
>
> ==> client.log <==
> 2013-10-14 20:50:32,626 - DEBUG - test_01_snapshot_root_disk (test_snapshots_fixed.TestSnapshotRootDisk) - Snapshot created: ID - b3161412-1cd3-4387-8bfb-aaa2ca
> 545eeb
> 2013-10-14 20:50:32,641 - DEBUG - test_01_snapshot_root_disk (test_snapshots_fixed.TestSnapshotRootDisk) - select backup_snap_id, account_id, volume_id from sna
> pshots where uuid = 'b3161412-1cd3-4387-8bfb-aaa2ca545eeb';
>
> ==> result.log <==
> test_01_snapshot_root_disk (test_snapshots_fixed.TestSnapshotRootDisk)
> Test Snapshot Root Disk ... ok
>
> ----------------------------------------------------------------------
> Ran 1 test in 259.875s
>
> OK
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 14646: CLOUDSTACK-4780:
Fixed-BVT-test-case-TestSnapshotRootDisk.test_01_snapshot_root_disk
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14646/#review27012
-----------------------------------------------------------
Ship it!
applied to master,4.2
- Prasanna Santhanam
On Oct. 15, 2013, 7:51 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14646/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2013, 7:51 a.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fixed-BVT-test-case-TestSnapshotRootDisk.test_01_snapshot_root_disk
> Used a utility function to check whether the snapshot exists in the secondary storage.
>
> This patch should be applied on top of https://reviews.apache.org/r/14346/ which contains the fix for the utility function used here.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_snapshots.py 06777e4
>
> Diff: https://reviews.apache.org/r/14646/diff/
>
>
> Testing
> -------
>
> Tested locally on KVM Advanced setup:
>
> ==> client.log <==
> 2013-10-14 20:50:32,626 - DEBUG - test_01_snapshot_root_disk (test_snapshots_fixed.TestSnapshotRootDisk) - Snapshot created: ID - b3161412-1cd3-4387-8bfb-aaa2ca
> 545eeb
> 2013-10-14 20:50:32,641 - DEBUG - test_01_snapshot_root_disk (test_snapshots_fixed.TestSnapshotRootDisk) - select backup_snap_id, account_id, volume_id from sna
> pshots where uuid = 'b3161412-1cd3-4387-8bfb-aaa2ca545eeb';
>
> ==> result.log <==
> test_01_snapshot_root_disk (test_snapshots_fixed.TestSnapshotRootDisk)
> Test Snapshot Root Disk ... ok
>
> ----------------------------------------------------------------------
> Ran 1 test in 259.875s
>
> OK
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 14646: CLOUDSTACK-4780:
Fixed-BVT-test-case-TestSnapshotRootDisk.test_01_snapshot_root_disk
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14646/#review27010
-----------------------------------------------------------
Commit 986ac0f124ab2960e13455736dfd467350e7f9e1 in branch refs/heads/master from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=986ac0f ]
CLOUDSTACK-4780: Fixed BVT test case TestSnapshotRootDisk.test_01_snapshot_root_disk
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
- ASF Subversion and Git Services
On Oct. 15, 2013, 7:51 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14646/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2013, 7:51 a.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fixed-BVT-test-case-TestSnapshotRootDisk.test_01_snapshot_root_disk
> Used a utility function to check whether the snapshot exists in the secondary storage.
>
> This patch should be applied on top of https://reviews.apache.org/r/14346/ which contains the fix for the utility function used here.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_snapshots.py 06777e4
>
> Diff: https://reviews.apache.org/r/14646/diff/
>
>
> Testing
> -------
>
> Tested locally on KVM Advanced setup:
>
> ==> client.log <==
> 2013-10-14 20:50:32,626 - DEBUG - test_01_snapshot_root_disk (test_snapshots_fixed.TestSnapshotRootDisk) - Snapshot created: ID - b3161412-1cd3-4387-8bfb-aaa2ca
> 545eeb
> 2013-10-14 20:50:32,641 - DEBUG - test_01_snapshot_root_disk (test_snapshots_fixed.TestSnapshotRootDisk) - select backup_snap_id, account_id, volume_id from sna
> pshots where uuid = 'b3161412-1cd3-4387-8bfb-aaa2ca545eeb';
>
> ==> result.log <==
> test_01_snapshot_root_disk (test_snapshots_fixed.TestSnapshotRootDisk)
> Test Snapshot Root Disk ... ok
>
> ----------------------------------------------------------------------
> Ran 1 test in 259.875s
>
> OK
>
>
> Thanks,
>
> Gaurav Aradhye
>
>