[GitHub] [spark] huaxingao commented on pull request #29868: [SPARK-32973][ML][DOC] FeatureHasher does not check categoricalCols in inputCols

[GitBox <gi...@apache.org>]

huaxingao commented on pull request #29868:
URL: https://github.com/apache/spark/pull/29868#issuecomment-698714611


   The change looks good to me, but do you need to change the implementation in https://github.com/apache/spark/pull/29850 ? Seems in that PR you are assuming ` categoricalCols` is always set in `inputCols`?
   ```
       if (isSet(categoricalCols)) catCols = (catCols ++ $(categoricalCols)).distinct
       val catIndices = catCols.map(c => localInputCols.indexOf(c))
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org