You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2014/09/18 17:03:42 UTC

Review Request 25780: Mesos: Replace os::Release with Version.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25780/
-----------------------------------------------------------

Review request for mesos and Ben Mahler.


Repository: mesos-git


Description
-------

Reflects updates made to stout/os.hpp, which now uses Version instead of os::Release.


Diffs
-----

  src/linux/perf.cpp 1a851a11abb1292eeb2267ed679c68fbb5aa8290 

Diff: https://reviews.apache.org/r/25780/diff/


Testing
-------

Ran make check.


Thanks,

Kapil Arya


Re: Review Request 25780: Mesos: Replace os::Release with Version.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25780/#review53876
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On Sept. 18, 2014, 3:07 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25780/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2014, 3:07 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Reflects updates made to stout/os.hpp, which now uses Version instead of os::Release.
> 
> 
> Diffs
> -----
> 
>   src/linux/perf.cpp 1a851a11abb1292eeb2267ed679c68fbb5aa8290 
> 
> Diff: https://reviews.apache.org/r/25780/diff/
> 
> 
> Testing
> -------
> 
> Ran make check.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Re: Review Request 25780: Mesos: Replace os::Release with Version.

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25780/#review53827
-----------------------------------------------------------


Patch looks great!

Reviews applied: [25755, 25780]

All tests passed.

- Mesos ReviewBot


On Sept. 18, 2014, 3:07 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25780/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2014, 3:07 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Reflects updates made to stout/os.hpp, which now uses Version instead of os::Release.
> 
> 
> Diffs
> -----
> 
>   src/linux/perf.cpp 1a851a11abb1292eeb2267ed679c68fbb5aa8290 
> 
> Diff: https://reviews.apache.org/r/25780/diff/
> 
> 
> Testing
> -------
> 
> Ran make check.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Re: Review Request 25780: Mesos: Replace os::Release with Version.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25780/
-----------------------------------------------------------

(Updated Sept. 18, 2014, 11:07 a.m.)


Review request for mesos and Ben Mahler.


Changes
-------

Added dependency on https://reviews.apache.org/r/25755/


Repository: mesos-git


Description
-------

Reflects updates made to stout/os.hpp, which now uses Version instead of os::Release.


Diffs
-----

  src/linux/perf.cpp 1a851a11abb1292eeb2267ed679c68fbb5aa8290 

Diff: https://reviews.apache.org/r/25780/diff/


Testing
-------

Ran make check.


Thanks,

Kapil Arya