You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hivemall.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/10/31 10:21:00 UTC

[jira] [Commented] (HIVEMALL-275) Fix xgboost module to create DMatrix from CSRMatrix

    [ https://issues.apache.org/jira/browse/HIVEMALL-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16963840#comment-16963840 ] 

ASF GitHub Bot commented on HIVEMALL-275:
-----------------------------------------

myui commented on pull request #211: [WIP][HIVEMALL-275] Fix xgboost module to create DMatrix from CSRMatrix
URL: https://github.com/apache/incubator-hivemall/pull/211
 
 
   ## What changes were proposed in this pull request?
   
   Fix xgboost module to create DMatrix from CSRMatrix
   
   ## What type of PR is it?
   
   Refactoring
   
   ## What is the Jira issue?
   
   https://issues.apache.org/jira/browse/HIVEMALL-275
   
   ## How was this patch tested?
   
   unit tests and manual tests on EMR
   
   ## How to use this feature?
   
   as seen in https://gist.github.com/myui/aa6e142a95ca8f995cc8e49146dbe2eb
   
   ## Checklist
   
   - [x] Did you apply source code formatter, i.e., `./bin/format_code.sh`, for your commit?
   - [ ] Did you run system tests on Hive (or Spark)?
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Fix xgboost module to create DMatrix from CSRMatrix
> ---------------------------------------------------
>
>                 Key: HIVEMALL-275
>                 URL: https://issues.apache.org/jira/browse/HIVEMALL-275
>             Project: Hivemall
>          Issue Type: Improvement
>            Reporter: Makoto Yui
>            Assignee: Makoto Yui
>            Priority: Minor
>             Fix For: 0.6.0
>
>
> DMatrix is created from LabelPoints but it consumes memory. So, support creating DMatrix directory from CSR matrix using [matrix4j|#L71].
> [https://github.com/dmlc/xgboost/blob/master/jvm-packages/xgboost4j/src/test/java/ml/dmlc/xgboost4j/java/DMatrixTest.java#L134]]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)