[GitHub] [incubator-superset] villebro commented on a change in pull request #7453: [WIP] Refine table name handling in SQL Lab

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #7453: [WIP] Refine table name handling in SQL Lab
URL: https://github.com/apache/incubator-superset/pull/7453#discussion_r283083711
 
 

 ##########
 File path: superset/db_engine_specs.py
 ##########
 @@ -279,33 +280,32 @@ def convert_dttm(cls, target_type, dttm):
         return "'{}'".format(dttm.strftime('%Y-%m-%d %H:%M:%S'))
 
     @classmethod
-    def fetch_result_sets(cls, db, datasource_type):
-        """Returns a list of tables [schema1.table1, schema2.table2, ...]
+    def get_all_datasource_names(cls, db, datasource_type: str) \
 
 Review comment:
   The reason `db` wasn't type annotated is because it caused a circular import (`models.core` already has a reference to `db_engine_specs`). This should probably be refactored, but is outside the scope of this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org