You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "olehborysevych (via GitHub)" <gi...@apache.org> on 2023/03/06 10:58:57 UTC
[GitHub] [beam] olehborysevych commented on a diff in pull request #24920: Tourofbeam+infrastructure
olehborysevych commented on code in PR #24920:
URL: https://github.com/apache/beam/pull/24920#discussion_r1114380643
##########
.gitignore:
##########
@@ -139,3 +139,5 @@ playground/frontend/playground_components_dev/pubspec.lock
# Ignore Katas auto-generated files
**/*-remote-info.yaml
+*.dart
Review Comment:
I don't think we need to ignore *.dart files ))
##########
.gitignore:
##########
@@ -139,3 +139,5 @@ playground/frontend/playground_components_dev/pubspec.lock
# Ignore Katas auto-generated files
**/*-remote-info.yaml
+*.dart
Review Comment:
also let's put the whole path to pubspec.lock and move it higher in the Dart/Flutter section
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org