You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Siddharth Srivastava (JIRA)" <ji...@apache.org> on 2012/07/04 03:13:34 UTC
[jira] [Created] (DERBY-5843) Remove unused method in
CharacterStreamDescriptor
Siddharth Srivastava created DERBY-5843:
-------------------------------------------
Summary: Remove unused method in CharacterStreamDescriptor
Key: DERBY-5843
URL: https://issues.apache.org/jira/browse/DERBY-5843
Project: Derby
Issue Type: Sub-task
Reporter: Siddharth Srivastava
Priority: Minor
Following function is not used:
public String toString()
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5843) Remove unused method in
CharacterStreamDescriptor
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409643#comment-13409643 ]
Kathey Marsden commented on DERBY-5843:
---------------------------------------
Removing a toString() method might be a bit tricky as it is not always invoked with the toString() method explicitly but rather would also be called by just adding the object to an output stream (probably the derby.log) by just adding + csd where csd is a CharacterStreamDescriptor object.
Such verbose output can occur with some of the debug properties, e.g:
http://wiki.apache.org/db-derby/DebugPropertiesTmpl
I don't know that that this particular object is ever printed with the debug options or a good way to check if it is. Also I know where toString() exist I have found them convenient when looking at values in the debugger. I think I would be a bit wary of removing toString() methods.
Just my opinion though.
> Remove unused method in CharacterStreamDescriptor
> -------------------------------------------------
>
> Key: DERBY-5843
> URL: https://issues.apache.org/jira/browse/DERBY-5843
> Project: Derby
> Issue Type: Sub-task
> Reporter: Siddharth Srivastava
> Assignee: Siddharth Srivastava
> Priority: Minor
> Attachments: Derby5843.patch
>
>
> Following function is not used:
> public String toString()
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5843) Remove unused method in
CharacterStreamDescriptor
Posted by "Siddharth Srivastava (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siddharth Srivastava updated DERBY-5843:
----------------------------------------
Attachment: Derby5843.patch
I have ran regression tests after applying this patch and didn't face any failures. But I am not sure if this function is there for generic reasons or is it really useful from a user point of view.
> Remove unused method in CharacterStreamDescriptor
> -------------------------------------------------
>
> Key: DERBY-5843
> URL: https://issues.apache.org/jira/browse/DERBY-5843
> Project: Derby
> Issue Type: Sub-task
> Reporter: Siddharth Srivastava
> Assignee: Siddharth Srivastava
> Priority: Minor
> Attachments: Derby5843.patch
>
>
> Following function is not used:
> public String toString()
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (DERBY-5843) Remove unused method in
CharacterStreamDescriptor
Posted by "Siddharth Srivastava (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siddharth Srivastava reassigned DERBY-5843:
-------------------------------------------
Assignee: Siddharth Srivastava
> Remove unused method in CharacterStreamDescriptor
> -------------------------------------------------
>
> Key: DERBY-5843
> URL: https://issues.apache.org/jira/browse/DERBY-5843
> Project: Derby
> Issue Type: Sub-task
> Reporter: Siddharth Srivastava
> Assignee: Siddharth Srivastava
> Priority: Minor
>
> Following function is not used:
> public String toString()
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira