You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/06 15:19:54 UTC

[GitHub] [pulsar] merlimat commented on a diff in pull request #15942: [feature][broker] Support HTTP endpoint consume messages

merlimat commented on code in PR #15942:
URL: https://github.com/apache/pulsar/pull/15942#discussion_r890262298


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/rest/TopicsBase.java:
##########
@@ -101,7 +117,11 @@
 @Slf4j
 public class TopicsBase extends PersistentTopicsBase {
 
+    private static final Map<String, Consumer<org.apache.pulsar.client.api.schema.GenericRecord>>

Review Comment:
   That is not a good model. It will create a very difficult API to use for the user. We need to do it such that it doesn’t matter which broker the consumer will hit. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org