You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by venkat sairam <ve...@gmail.com> on 2017/03/27 13:09:06 UTC

Review Request 57956: Pig view doesn't load in older version of firefox

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57956/
-----------------------------------------------------------

Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-20584
    https://issues.apache.org/jira/browse/AMBARI-20584


Repository: ambari


Description
-------

ES6 syntax specifications which are not supported in older versions of browsers are removed


Diffs
-----

  contrib/views/pig/src/main/resources/ui/pig-web/app/controllers/splash.js 4451b84 
  contrib/views/pig/src/main/resources/ui/pig-web/app/routes/splash.js 5cfeac7 


Diff: https://reviews.apache.org/r/57956/diff/1/


Testing
-------

Manual testing done


Thanks,

venkat sairam


Re: Review Request 57956: Pig view doesn't load in older version of firefox

Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57956/#review170171
-----------------------------------------------------------


Ship it!




Ship It!

- Pallav Kulshreshtha


On March 27, 2017, 1:09 p.m., venkat sairam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57956/
> -----------------------------------------------------------
> 
> (Updated March 27, 2017, 1:09 p.m.)
> 
> 
> Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-20584
>     https://issues.apache.org/jira/browse/AMBARI-20584
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> ES6 syntax specifications which are not supported in older versions of browsers are removed
> 
> 
> Diffs
> -----
> 
>   contrib/views/pig/src/main/resources/ui/pig-web/app/controllers/splash.js 4451b84 
>   contrib/views/pig/src/main/resources/ui/pig-web/app/routes/splash.js 5cfeac7 
> 
> 
> Diff: https://reviews.apache.org/r/57956/diff/1/
> 
> 
> Testing
> -------
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>


Re: Review Request 57956: Pig view doesn't load in older version of firefox

Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57956/#review170167
-----------------------------------------------------------


Ship it!




Ship It!

- Gaurav Nagar


On March 27, 2017, 1:09 p.m., venkat sairam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57956/
> -----------------------------------------------------------
> 
> (Updated March 27, 2017, 1:09 p.m.)
> 
> 
> Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-20584
>     https://issues.apache.org/jira/browse/AMBARI-20584
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> ES6 syntax specifications which are not supported in older versions of browsers are removed
> 
> 
> Diffs
> -----
> 
>   contrib/views/pig/src/main/resources/ui/pig-web/app/controllers/splash.js 4451b84 
>   contrib/views/pig/src/main/resources/ui/pig-web/app/routes/splash.js 5cfeac7 
> 
> 
> Diff: https://reviews.apache.org/r/57956/diff/1/
> 
> 
> Testing
> -------
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>