You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-commits@db.apache.org by da...@apache.org on 2013/06/28 15:32:54 UTC
svn commit: r1497767 -
/db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/FromSubquery.java
Author: dag
Date: Fri Jun 28 13:32:54 2013
New Revision: 1497767
URL: http://svn.apache.org/r1497767
Log:
DERBY-673: Get rid of the NodeFactory
Followup fix to patch derby-673-typesafe-lists-2. The patch introduced
a bug in FromSubquery: wrong loop upper bound. Roll back that change.
Modified:
db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/FromSubquery.java
Modified: db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/FromSubquery.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/FromSubquery.java?rev=1497767&r1=1497766&r2=1497767&view=diff
==============================================================================
--- db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/FromSubquery.java (original)
+++ db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/FromSubquery.java Fri Jun 28 13:32:54 2013
@@ -631,8 +631,11 @@ class FromSubquery extends FromTable
// Use visibleSize, because we don't want to propagate any order by
// columns not selected.
- for (ResultColumn resultColumn : resultColumns)
+ int rclSize = resultColumns.visibleSize();
+
+ for (int index = 0; index < rclSize; index++)
{
+ ResultColumn resultColumn = resultColumns.elementAt(index);
ValueNode valueNode;
String columnName;