You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "zihaoAK47 (via GitHub)" <gi...@apache.org> on 2023/05/21 03:29:38 UTC
[GitHub] [shardingsphere] zihaoAK47 opened a new pull request, #25814: Change GRANT_PROXY enum value Spelling
zihaoAK47 opened a new pull request, #25814:
URL: https://github.com/apache/shardingsphere/pull/25814
Refer #25535.
Changes proposed in this pull request:
- Change GRANT_PROXY enum value Spelling
- Add test sql
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ✓] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ✓] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ✓] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ✓] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #25814: Change GRANT_PROXY enum value Spelling
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu merged PR #25814:
URL: https://github.com/apache/shardingsphere/pull/25814
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zihaoAK47 commented on pull request #25814: Change GRANT_PROXY enum value Spelling
Posted by "zihaoAK47 (via GitHub)" <gi...@apache.org>.
zihaoAK47 commented on PR #25814:
URL: https://github.com/apache/shardingsphere/pull/25814#issuecomment-1560348555
@strongduanmu Hi mentor please review.
Should we consider making the valueOf method in SQLVisitorRule class ignore case sensitivity when comparing? This could potentially prevent exceptions caused by misspelled rule names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on pull request #25814: Change GRANT_PROXY enum value Spelling
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on PR #25814:
URL: https://github.com/apache/shardingsphere/pull/25814#issuecomment-1560353531
> @strongduanmu Hi mentor please review. Should we consider making the valueOf method in SQLVisitorRule class ignore case sensitivity when comparing? This could potentially prevent exceptions caused by misspelled rule names.
I think more careful code review can avoid this problem. We can't write compatibility code for a mistake, what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org