[GitHub] [samza] prateekm commented on a change in pull request #1160: Transactional State [1/5]: Added Store Checkpoint API

[GitBox <gi...@apache.org>]

prateekm commented on a change in pull request #1160: Transactional State [1/5]: Added Store Checkpoint API
URL: https://github.com/apache/samza/pull/1160#discussion_r326751049
 
 

 ##########
 File path: samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala
 ##########
 @@ -236,6 +239,13 @@ class RocksDbKeyValueStore(
     trace("Flushed store: %s" format storeName)
   }
 
+  override def checkpoint(id: String): Optional[Path] = {
+    val checkpoint = Checkpoint.create(db)
+    val checkpointPath = dir.getPath + "-" + id
 
 Review comment:
   RocksDB checkpoint dir is required to be unique. Otherwise RocksDB will throw: `org.rocksdb.RocksDBException: Directory exists`
   
   In part 5, id will be created using (current time millis + last 3 digit of nanotime), so the directory will typically be unique.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services