[GitHub] [pulsar] Heiss opened a new pull request #4867: [Dashboard] requests should respect no_proxy env variable

[GitBox <gi...@apache.org>]

Heiss opened a new pull request #4867: [Dashboard] requests should respect no_proxy env variable
URL: https://github.com/apache/pulsar/pull/4867
 
 
   If you want to specify a no_proxy variable in your dockerfile or docker-compose.yml, then this little fix respects the variable in get-requests. Otherwise the proxies could break your docker namespace lookup.
   
   ### Motivation
   
   I try to run pulsar and dashboard in a docker-compose.yml, but my http_proxies broke the service-namespace lookup. So i had to exlude the service-name from the proxy, but the dashboard ignores the no_proxy variable.
   
   ### Modifications
   
   Added os.getenv["NO_PROXY"] to http_proxyes.
   
   ### Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
     - Anything that affects deployment: yes
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services