You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2012/05/02 20:08:51 UTC
[jira] [Created] (HBASE-5919) Add missing Ted review fixes for
HBASE-5869
stack created HBASE-5919:
----------------------------
Summary: Add missing Ted review fixes for HBASE-5869
Key: HBASE-5919
URL: https://issues.apache.org/jira/browse/HBASE-5919
Project: HBase
Issue Type: Bug
Reporter: stack
Priority: Blocker
I missed addressing a few of Ted's comments on the end of my navigating HBASE-5869 commit. Fix here. Make it a blocker.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5919) Add missing Ted review fixes for
HBASE-5869
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266985#comment-13266985 ]
Hadoop QA commented on HBASE-5919:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12525356/5919.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 hadoop23. The patch compiles against the hadoop 0.23.x profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestCatalogJanitor
org.apache.hadoop.hbase.regionserver.TestResettingCounters
org.apache.hadoop.hbase.regionserver.TestScanWithBloomError
org.apache.hadoop.hbase.regionserver.TestColumnSeeking
org.apache.hadoop.hbase.client.TestResult
org.apache.hadoop.hbase.regionserver.TestStoreFile
org.apache.hadoop.hbase.filter.TestDependentColumnFilter
org.apache.hadoop.hbase.regionserver.TestMemStore
org.apache.hadoop.hbase.io.hfile.TestSeekTo
org.apache.hadoop.hbase.TestKeyValue
org.apache.hadoop.hbase.filter.TestFilter
org.apache.hadoop.hbase.regionserver.TestScanner
org.apache.hadoop.hbase.TestSerialization
org.apache.hadoop.hbase.regionserver.TestCompaction
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1730//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1730//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1730//console
This message is automatically generated.
> Add missing Ted review fixes for HBASE-5869
> -------------------------------------------
>
> Key: HBASE-5919
> URL: https://issues.apache.org/jira/browse/HBASE-5919
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Priority: Blocker
> Attachments: 5919.txt
>
>
> I missed addressing a few of Ted's comments on the end of my navigating HBASE-5869 commit. Fix here. Make it a blocker.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5919) Add fixes for Ted's review comments
from HBASE-5869
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267212#comment-13267212 ]
Hudson commented on HBASE-5919:
-------------------------------
Integrated in HBase-TRUNK #2841 (See [https://builds.apache.org/job/HBase-TRUNK/2841/])
HBASE-5919 Add fixes for Ted's review comments from HBASE-5869 (Revision 1333304)
Result = SUCCESS
tedyu :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/Bytes.java
> Add fixes for Ted's review comments from HBASE-5869
> ---------------------------------------------------
>
> Key: HBASE-5919
> URL: https://issues.apache.org/jira/browse/HBASE-5919
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: Ted Yu
> Priority: Blocker
> Attachments: 5919-v2.txt, 5919-v4.txt, 5919.txt
>
>
> I missed addressing a few of Ted's comments on the end of my navigating HBASE-5869 commit. Fix here. Make it a blocker.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5919) Add fixes for Ted's review comments
from HBASE-5869
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5919:
------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Add fixes for Ted's review comments from HBASE-5869
> ---------------------------------------------------
>
> Key: HBASE-5919
> URL: https://issues.apache.org/jira/browse/HBASE-5919
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: Ted Yu
> Priority: Blocker
> Attachments: 5919-v2.txt, 5919-v4.txt, 5919.txt
>
>
> I missed addressing a few of Ted's comments on the end of my navigating HBASE-5869 commit. Fix here. Make it a blocker.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5919) Add missing Ted review fixes for
HBASE-5869
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267054#comment-13267054 ]
Hadoop QA commented on HBASE-5919:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12525361/5919-v2.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 hadoop23. The patch compiles against the hadoop 0.23.x profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1732//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1732//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1732//console
This message is automatically generated.
> Add missing Ted review fixes for HBASE-5869
> -------------------------------------------
>
> Key: HBASE-5919
> URL: https://issues.apache.org/jira/browse/HBASE-5919
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Priority: Blocker
> Attachments: 5919-v2.txt, 5919.txt
>
>
> I missed addressing a few of Ted's comments on the end of my navigating HBASE-5869 commit. Fix here. Make it a blocker.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5919) Add fixes for Ted's review comments
from HBASE-5869
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267142#comment-13267142 ]
Zhihong Yu commented on HBASE-5919:
-----------------------------------
I looped TestAssignmentManager based on patch v4 5 times.
They passed.
I think patch v4 should be good to go.
> Add fixes for Ted's review comments from HBASE-5869
> ---------------------------------------------------
>
> Key: HBASE-5919
> URL: https://issues.apache.org/jira/browse/HBASE-5919
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Priority: Blocker
> Attachments: 5919-v2.txt, 5919-v4.txt, 5919.txt
>
>
> I missed addressing a few of Ted's comments on the end of my navigating HBASE-5869 commit. Fix here. Make it a blocker.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5919) Add fixes for Ted's review comments
from HBASE-5869
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267166#comment-13267166 ]
Zhihong Yu commented on HBASE-5919:
-----------------------------------
Integrated to trunk.
Thanks for the review, Stack.
> Add fixes for Ted's review comments from HBASE-5869
> ---------------------------------------------------
>
> Key: HBASE-5919
> URL: https://issues.apache.org/jira/browse/HBASE-5919
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: Ted Yu
> Priority: Blocker
> Attachments: 5919-v2.txt, 5919-v4.txt, 5919.txt
>
>
> I missed addressing a few of Ted's comments on the end of my navigating HBASE-5869 commit. Fix here. Make it a blocker.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5919) Add missing Ted review fixes for
HBASE-5869
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5919:
-------------------------
Status: Patch Available (was: Open)
> Add missing Ted review fixes for HBASE-5869
> -------------------------------------------
>
> Key: HBASE-5919
> URL: https://issues.apache.org/jira/browse/HBASE-5919
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Priority: Blocker
> Attachments: 5919.txt
>
>
> I missed addressing a few of Ted's comments on the end of my navigating HBASE-5869 commit. Fix here. Make it a blocker.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5919) Add missing Ted review fixes for
HBASE-5869
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267115#comment-13267115 ]
Hadoop QA commented on HBASE-5919:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12525375/5919-v3.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 hadoop23. The patch compiles against the hadoop 0.23.x profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1735//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1735//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1735//console
This message is automatically generated.
> Add missing Ted review fixes for HBASE-5869
> -------------------------------------------
>
> Key: HBASE-5919
> URL: https://issues.apache.org/jira/browse/HBASE-5919
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Priority: Blocker
> Attachments: 5919-v2.txt, 5919-v3.txt, 5919.txt
>
>
> I missed addressing a few of Ted's comments on the end of my navigating HBASE-5869 commit. Fix here. Make it a blocker.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5919) Add fixes for Ted's review comments
from HBASE-5869
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267161#comment-13267161 ]
Zhihong Yu commented on HBASE-5919:
-----------------------------------
@Stack:
Do you have further comments about patch v4 ?
> Add fixes for Ted's review comments from HBASE-5869
> ---------------------------------------------------
>
> Key: HBASE-5919
> URL: https://issues.apache.org/jira/browse/HBASE-5919
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: Ted Yu
> Priority: Blocker
> Attachments: 5919-v2.txt, 5919-v4.txt, 5919.txt
>
>
> I missed addressing a few of Ted's comments on the end of my navigating HBASE-5869 commit. Fix here. Make it a blocker.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5919) Add missing Ted review fixes for
HBASE-5869
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266979#comment-13266979 ]
Zhihong Yu commented on HBASE-5919:
-----------------------------------
{code}
+ int length = Math.min(len - off, b.length - off);
{code}
I think len represents the length to write. So I am not sure why off would come into play above.
> Add missing Ted review fixes for HBASE-5869
> -------------------------------------------
>
> Key: HBASE-5919
> URL: https://issues.apache.org/jira/browse/HBASE-5919
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Priority: Blocker
> Attachments: 5919.txt
>
>
> I missed addressing a few of Ted's comments on the end of my navigating HBASE-5869 commit. Fix here. Make it a blocker.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5919) Add missing Ted review fixes for
HBASE-5869
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5919:
------------------------------
Attachment: 5919-v3.txt
> Add missing Ted review fixes for HBASE-5869
> -------------------------------------------
>
> Key: HBASE-5919
> URL: https://issues.apache.org/jira/browse/HBASE-5919
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Priority: Blocker
> Attachments: 5919-v2.txt, 5919-v3.txt, 5919.txt
>
>
> I missed addressing a few of Ted's comments on the end of my navigating HBASE-5869 commit. Fix here. Make it a blocker.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-5919) Add fixes for Ted's review comments
from HBASE-5869
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack reassigned HBASE-5919:
----------------------------
Assignee: Ted Yu
I thought this was my issue but you seem to have taken it over Ted. Assigning you.
> Add fixes for Ted's review comments from HBASE-5869
> ---------------------------------------------------
>
> Key: HBASE-5919
> URL: https://issues.apache.org/jira/browse/HBASE-5919
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: Ted Yu
> Priority: Blocker
> Attachments: 5919-v2.txt, 5919-v4.txt, 5919.txt
>
>
> I missed addressing a few of Ted's comments on the end of my navigating HBASE-5869 commit. Fix here. Make it a blocker.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5919) Add fixes for Ted's review comments
from HBASE-5869
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267223#comment-13267223 ]
Hudson commented on HBASE-5919:
-------------------------------
Integrated in HBase-TRUNK-security #190 (See [https://builds.apache.org/job/HBase-TRUNK-security/190/])
HBASE-5919 Add fixes for Ted's review comments from HBASE-5869 (Revision 1333304)
Result = SUCCESS
tedyu :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/Bytes.java
> Add fixes for Ted's review comments from HBASE-5869
> ---------------------------------------------------
>
> Key: HBASE-5919
> URL: https://issues.apache.org/jira/browse/HBASE-5919
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: Ted Yu
> Priority: Blocker
> Attachments: 5919-v2.txt, 5919-v4.txt, 5919.txt
>
>
> I missed addressing a few of Ted's comments on the end of my navigating HBASE-5869 commit. Fix here. Make it a blocker.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5919) Add missing Ted review fixes for
HBASE-5869
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5919:
-------------------------
Attachment: 5919.txt
Address issues raised by Ted over in hbase-5869 that I did not want to address there because the criticims' were relatively nits for a patch of > 300k. I'd gotten two clean hadoopqa builds on v13... and was afraid my patch would fail to apply if I did more hadoopqa cycles.
> Add missing Ted review fixes for HBASE-5869
> -------------------------------------------
>
> Key: HBASE-5919
> URL: https://issues.apache.org/jira/browse/HBASE-5919
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Priority: Blocker
> Attachments: 5919.txt
>
>
> I missed addressing a few of Ted's comments on the end of my navigating HBASE-5869 commit. Fix here. Make it a blocker.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5919) Add fixes for Ted's review comments
from HBASE-5869
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5919:
------------------------------
Comment: was deleted
(was: -1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12525375/5919-v3.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 hadoop23. The patch compiles against the hadoop 0.23.x profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1735//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1735//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1735//console
This message is automatically generated.)
> Add fixes for Ted's review comments from HBASE-5869
> ---------------------------------------------------
>
> Key: HBASE-5919
> URL: https://issues.apache.org/jira/browse/HBASE-5919
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Priority: Blocker
> Attachments: 5919-v2.txt, 5919-v4.txt, 5919.txt
>
>
> I missed addressing a few of Ted's comments on the end of my navigating HBASE-5869 commit. Fix here. Make it a blocker.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5919) Add missing Ted review fixes for
HBASE-5869
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5919:
------------------------------
Attachment: (was: 5919-v3.txt)
> Add missing Ted review fixes for HBASE-5869
> -------------------------------------------
>
> Key: HBASE-5919
> URL: https://issues.apache.org/jira/browse/HBASE-5919
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Priority: Blocker
> Attachments: 5919-v2.txt, 5919-v4.txt, 5919.txt
>
>
> I missed addressing a few of Ted's comments on the end of my navigating HBASE-5869 commit. Fix here. Make it a blocker.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5919) Add missing Ted review fixes for
HBASE-5869
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266981#comment-13266981 ]
stack commented on HBASE-5919:
------------------------------
Review how this method is called. Look up in the file two methods.
> Add missing Ted review fixes for HBASE-5869
> -------------------------------------------
>
> Key: HBASE-5919
> URL: https://issues.apache.org/jira/browse/HBASE-5919
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Priority: Blocker
> Attachments: 5919.txt
>
>
> I missed addressing a few of Ted's comments on the end of my navigating HBASE-5869 commit. Fix here. Make it a blocker.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5919) Add missing Ted review fixes for
HBASE-5869
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5919:
------------------------------
Attachment: 5919-v2.txt
Patch v2 gets past the following tests:
{code}
789 mt -Dtest=TestScanWithBloomError
790 mt -Dtest=TestFilter
{code}
> Add missing Ted review fixes for HBASE-5869
> -------------------------------------------
>
> Key: HBASE-5919
> URL: https://issues.apache.org/jira/browse/HBASE-5919
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Priority: Blocker
> Attachments: 5919-v2.txt, 5919.txt
>
>
> I missed addressing a few of Ted's comments on the end of my navigating HBASE-5869 commit. Fix here. Make it a blocker.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5919) Add fixes for Ted's review comments
from HBASE-5869
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5919:
------------------------------
Hadoop Flags: Reviewed
Summary: Add fixes for Ted's review comments from HBASE-5869 (was: Add missing Ted review fixes for HBASE-5869)
> Add fixes for Ted's review comments from HBASE-5869
> ---------------------------------------------------
>
> Key: HBASE-5919
> URL: https://issues.apache.org/jira/browse/HBASE-5919
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Priority: Blocker
> Attachments: 5919-v2.txt, 5919-v4.txt, 5919.txt
>
>
> I missed addressing a few of Ted's comments on the end of my navigating HBASE-5869 commit. Fix here. Make it a blocker.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5919) Add missing Ted review fixes for
HBASE-5869
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267138#comment-13267138 ]
Hadoop QA commented on HBASE-5919:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12525382/5919-v4.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 hadoop23. The patch compiles against the hadoop 0.23.x profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestAssignmentManager
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1737//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1737//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1737//console
This message is automatically generated.
> Add missing Ted review fixes for HBASE-5869
> -------------------------------------------
>
> Key: HBASE-5919
> URL: https://issues.apache.org/jira/browse/HBASE-5919
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Priority: Blocker
> Attachments: 5919-v2.txt, 5919-v4.txt, 5919.txt
>
>
> I missed addressing a few of Ted's comments on the end of my navigating HBASE-5869 commit. Fix here. Make it a blocker.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5919) Add fixes for Ted's review comments
from HBASE-5869
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267163#comment-13267163 ]
stack commented on HBASE-5919:
------------------------------
None.
> Add fixes for Ted's review comments from HBASE-5869
> ---------------------------------------------------
>
> Key: HBASE-5919
> URL: https://issues.apache.org/jira/browse/HBASE-5919
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: Ted Yu
> Priority: Blocker
> Attachments: 5919-v2.txt, 5919-v4.txt, 5919.txt
>
>
> I missed addressing a few of Ted's comments on the end of my navigating HBASE-5869 commit. Fix here. Make it a blocker.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5919) Add missing Ted review fixes for
HBASE-5869
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5919:
------------------------------
Attachment: 5919-v4.txt
> Add missing Ted review fixes for HBASE-5869
> -------------------------------------------
>
> Key: HBASE-5919
> URL: https://issues.apache.org/jira/browse/HBASE-5919
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Priority: Blocker
> Attachments: 5919-v2.txt, 5919-v4.txt, 5919.txt
>
>
> I missed addressing a few of Ted's comments on the end of my navigating HBASE-5869 commit. Fix here. Make it a blocker.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira