You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Throne3d (via GitHub)" <gi...@apache.org> on 2023/09/22 21:03:29 UTC

[GitHub] [airflow] Throne3d commented on issue #27561: Helm chart tries to patch immutable Job resources on helm upgrade

Throne3d commented on issue #27561:
URL: https://github.com/apache/airflow/issues/27561#issuecomment-1732030327

   Now ttlSecondsAfterFinished has been added, is the recommended approach still as documented? Reading the thread, it sounds like instead of (as in [the documentation](https://airflow.apache.org/docs/helm-chart/stable/index.html#installing-the-chart-with-argo-cd-flux-rancher-or-terraform)):
   
   ```yaml
   createUserJob:
     useHelmHooks: false
     applyCustomEnv: false
   migrateDatabaseJob:
     useHelmHooks: false
     applyCustomEnv: false
   ```
   the recommendation is instead again:
   ```yaml
   createUserJob:
     useHelmHooks: false
   migrateDatabaseJob:
     useHelmHooks: false
   ```
   making use of the implicit `ttlSecondsAfterFinished` to drop the jobs between deploys before the next patch comes along and tries to mutate immutable fields.
   
   Should I create a follow-up to update the documentation with this recommendation, and a caveat that deploys < ttlSecondsAfterFinished apart may still trigger the underlying Job mutation issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org