[jira] [Commented] (TAP5-2585) Expression Issues (CronExpression.java and GenericsUtils.java)

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAP5-2585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209057#comment-16209057 ] 

ASF subversion and git services commented on TAP5-2585:
-------------------------------------------------------

Commit c152c38f74d0439db33a951e87bb8dda25753d45 in tapestry-5's branch refs/heads/master from [~jkemnade]
[ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=c152c38 ]

TAP5-2585: Fix whitespace check


> Expression Issues (CronExpression.java and GenericsUtils.java)
> --------------------------------------------------------------
>
>                 Key: TAP5-2585
>                 URL: https://issues.apache.org/jira/browse/TAP5-2585
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-ioc
>    Affects Versions: 5.4.3
>            Reporter: AppChecker
>            Assignee: Jochen Kemnade
>              Labels: appchecker
>             Fix For: 5.5.0
>
>
> Hi
> Please look following fragments of source code:
> 1) [tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/cron/CronExpression.java#L937|https://github.com/apache/tapestry-5/blob/95a548ec488a3c09c16117a0e6f9d3ce28db0322/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/cron/CronExpression.java#L937]
> {code:java}for (; i < s.length() && (s.charAt(i) != ' ' || s.charAt(i) != '\t'); i++)
> {code}
> Expression (s.charAt\(i) != ' ' || s.charAt\(i) != '\t') is always true.
> Probably, is should be:
> {code:java}
> (s.charAt(i) != ' ' && s.charAt(i) != '\t')
> {code}
> 2) [commons/src/main/java/org/apache/tapestry5/ioc/internal/util/GenericsUtils.java#L577|https://github.com/apache/tapestry-5/blob/95a548ec488a3c09c16117a0e6f9d3ce28db0322/commons/src/main/java/org/apache/tapestry5/ioc/internal/util/GenericsUtils.java#L577]
> {code:java}
> isSuper ? toString(wt.getLowerBounds()) : toString(wt.getLowerBounds()));
> {code}
> It is strange that the parts of the ternary operator are same.
> These possible defect found by [AppChecker|https://npo-echelon.ru/en/solutions/appchecker.php].



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)